From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755557AbbBBXuk (ORCPT ); Mon, 2 Feb 2015 18:50:40 -0500 Received: from mail-la0-f45.google.com ([209.85.215.45]:64670 "EHLO mail-la0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755319AbbBBXue (ORCPT ); Mon, 2 Feb 2015 18:50:34 -0500 From: Rasmus Villemoes To: Andrew Morton , Vlastimil Babka , Rik van Riel , Joonsoo Kim Cc: Rasmus Villemoes , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/5] mm/internal.h: Don't split printk call in two Date: Tue, 3 Feb 2015 00:50:12 +0100 Message-Id: <1422921016-27618-2-git-send-email-linux@rasmusvillemoes.dk> X-Mailer: git-send-email 2.1.3 In-Reply-To: <1422921016-27618-1-git-send-email-linux@rasmusvillemoes.dk> References: <1422921016-27618-1-git-send-email-linux@rasmusvillemoes.dk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org All users of mminit_dprintk pass a compile-time constant as level, so this just makes gcc emit a single printk call instead of two. Signed-off-by: Rasmus Villemoes --- Notes: Not a huge deal, since the only users are __init or __meminit functions, but even there saving 140 bytes may be worthwhile. mm/internal.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/mm/internal.h b/mm/internal.h index efad241f7014..e1d8e05bcfff 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -329,8 +329,10 @@ extern int mminit_loglevel; #define mminit_dprintk(level, prefix, fmt, arg...) \ do { \ if (level < mminit_loglevel) { \ - printk(level <= MMINIT_WARNING ? KERN_WARNING : KERN_DEBUG); \ - printk(KERN_CONT "mminit::" prefix " " fmt, ##arg); \ + if (level <= MMINIT_WARNING) \ + printk(KERN_WARNING "mminit::" prefix " " fmt, ##arg); \ + else \ + printk(KERN_DEBUG "mminit::" prefix " " fmt, ##arg); \ } \ } while (0) -- 2.1.3