From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755579AbbBCKGx (ORCPT ); Tue, 3 Feb 2015 05:06:53 -0500 Received: from mail-bn1on0141.outbound.protection.outlook.com ([157.56.110.141]:27235 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752291AbbBCKGt (ORCPT ); Tue, 3 Feb 2015 05:06:49 -0500 X-WSS-ID: 0NJ6XF6-08-H29-02 X-M-MSG: Message-ID: <1422957325.18208.13.camel@kxue-X58A-UD3R> Subject: Re: [PATCH V2] acpi:apd:add AMD ACPI2Platform device support for x86 system. From: Ken Xue To: "mika.westerberg@linux.intel.com" CC: "Rafael J. Wysocki" , "andy.shevchenko@gmail.com" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Date: Tue, 3 Feb 2015 17:55:25 +0800 In-Reply-To: <20150203095307.GB1465@lahna.fi.intel.com> References: <1422870652.2528.6.camel@kxue-X58A-UD3R> <20150202130356.GS22740@lahna.fi.intel.com> <1422925495.2528.12.camel@kxue-X58A-UD3R> <20150203095307.GB1465@lahna.fi.intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 Authentication-Results: spf=none (sender IP is 165.204.84.222) smtp.mailfrom=Ken.Xue@amd.com; gmail.com; dkim=none (message not signed) header.d=none; X-Forefront-Antispam-Report: CIP:165.204.84.222;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(24454002)(377424004)(51704005)(50986999)(62966003)(87936001)(86362001)(93886004)(47776003)(2501002)(23676002)(77156002)(33646002)(50466002)(76176999)(33716001)(46102003)(105586002)(92566002)(101416001)(2950100001)(19580395003)(106466001)(110136001)(50226001)(2351001)(77096005)(19580405001)(103116003)(3940600001);DIR:OUT;SFP:1102;SCL:1;SRVR:BN1PR02MB197;H:atltwp02.amd.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Antispam: UriScan:;UriScan:; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:BN1PR02MB197; X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004);SRVR:BN1PR02MB197; X-Forefront-PRVS: 0476D4AB88 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:;SRVR:BN1PR02MB197; X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2015 10:06:44.8557 (UTC) X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96;Ip=[165.204.84.222] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR02MB197 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:BN1PR02MB102; X-OriginatorOrg: amd4.onmicrosoft.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-02-03 at 11:53 +0200, mika.westerberg@linux.intel.com wrote: > On Tue, Feb 03, 2015 at 09:04:55AM +0800, Ken Xue wrote: > > as you said, platform_drv_probe calls dev_pm_domain_attach(). but > > platform_drv_probe just is a default probe routine. Not all platform > > device drivers use this probe routine. so, codes here may be still > > necessary. > > Are you saying that for platform devices there is some other path to get > a driver probed, other than platform_drv_probe()? Can you point me to > it? >>From the codes, i can see there is a possibility that drv->driver.probe may not be set in __platform_driver_register. But i really can not point out a use case that platform device driver without probe. so, it is safe to remove "dev_pm_domain_attach" in "acpi_apd_platform_notify". right?