mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <Arun.Ramadoss@microchip.com>
To: <andrew@lunn.ch>, <olteanv@gmail.com>, <davem@davemloft.net>,
	<Woojung.Huh@microchip.com>, <pabeni@redhat.com>,
	<o.rempel@pengutronix.de>, <edumazet@google.com>,
	<f.fainelli@gmail.com>, <kuba@kernel.org>
Cc: <kernel@pengutronix.de>, <san@skov.dk>,
	<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
	<UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH net-next v2 3/8] net: dsa: microchip: ksz8: Refactor ksz8_fdb_dump()
Date: Thu, 4 Apr 2024 03:18:44 +0000	[thread overview]
Message-ID: <142295fe6bb947763e313f99b6b4f75a10def1d2.camel@microchip.com> (raw)
In-Reply-To: <20240403125039.3414824-4-o.rempel@pengutronix.de>

Hi Oleksij,

On Wed, 2024-04-03 at 14:50 +0200, Oleksij Rempel wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> Refactor ksz8_fdb_dump() to address potential issues:
> - Limit the number of iterations to avoid endless loops.
> - Handle error codes returned by ksz8_r_dyn_mac_table(), with
>   an exception for -ENXIO when no more dynamic entries are detected.
> 
> Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>

I believe Signed-off-by tag should be first followed by the
Acked/reviewed tag in the order who reviewed it to indicate
chronological order. Correct me if I am wrong. 

Acked-by: Arun Ramadoss <arun.ramadoss@microchip.com>


  parent reply	other threads:[~2024-04-04  3:18 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-03 12:50 [PATCH net-next v2 0/8] net: dsa: microchip: ksz8: refactor FDB dump path Oleksij Rempel
2024-04-03 12:50 ` [PATCH net-next v2 1/8] net: dsa: microchip: Remove unused FDB timestamp support in ksz8_r_dyn_mac_table() Oleksij Rempel
2024-04-03 13:00   ` Florian Fainelli
2024-04-03 12:50 ` [PATCH net-next v2 2/8] net: dsa: microchip: Make ksz8_r_dyn_mac_table() static Oleksij Rempel
2024-04-03 13:01   ` Florian Fainelli
2024-04-03 12:50 ` [PATCH net-next v2 3/8] net: dsa: microchip: ksz8: Refactor ksz8_fdb_dump() Oleksij Rempel
2024-04-03 13:01   ` Florian Fainelli
2024-04-04  3:18   ` Arun.Ramadoss [this message]
2024-04-03 12:50 ` [PATCH net-next v2 4/8] net: dsa: microchip: ksz8: Refactor ksz8_r_dyn_mac_table() for readability Oleksij Rempel
2024-04-03 13:02   ` Florian Fainelli
2024-04-03 12:50 ` [PATCH net-next v2 5/8] net: dsa: microchip: ksz8: Unify variable naming in ksz8_r_dyn_mac_table() Oleksij Rempel
2024-04-03 13:02   ` Florian Fainelli
2024-04-03 12:50 ` [PATCH net-next v2 6/8] net: dsa: microchip: ksz8_r_dyn_mac_table(): ksz: do not return EAGAIN on timeout Oleksij Rempel
2024-04-03 13:03   ` Florian Fainelli
2024-04-03 12:50 ` [PATCH net-next v2 7/8] net: dsa: microchip: ksz8_r_dyn_mac_table(): return read/write error if we got any Oleksij Rempel
2024-04-03 13:03   ` Florian Fainelli
2024-04-03 12:50 ` [PATCH net-next v2 8/8] net: dsa: microchip: ksz8_r_dyn_mac_table(): use entries variable to signal 0 entries Oleksij Rempel
2024-04-03 13:04   ` Florian Fainelli
2024-04-05  2:40 ` [PATCH net-next v2 0/8] net: dsa: microchip: ksz8: refactor FDB dump path patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=142295fe6bb947763e313f99b6b4f75a10def1d2.camel@microchip.com \
    --to=arun.ramadoss@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=Woojung.Huh@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=san@skov.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®