From: Daniel Sanders <daniel.sanders@imgtec.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Toma Tabacu <toma.tabacu@imgtec.com>,
Daniel Sanders <daniel.sanders@imgtec.com>,
Ralf Baechle <ralf@linux-mips.org>,
Andreas Herrmann <andreas.herrmann@caviumnetworks.com>,
David Daney <david.daney@cavium.com>,
Manuel Lauss <manuel.lauss@gmail.com>,
<linux-mips@linux-mips.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/5] MIPS: LLVMLinux: Fix a 'cast to type not present in union' error.
Date: Tue, 3 Feb 2015 13:37:16 +0000 [thread overview]
Message-ID: <1422970639-7922-3-git-send-email-daniel.sanders@imgtec.com> (raw)
In-Reply-To: <1422970639-7922-1-git-send-email-daniel.sanders@imgtec.com>
From: Toma Tabacu <toma.tabacu@imgtec.com>
Remove a cast to the 'mips16e_instruction' union inside an if
condition and instead do an assignment to a local
'union mips16e_instruction' variable's 'full' member before the if
statement and use this variable in the if condition.
This is the error message reported by clang:
arch/mips/kernel/branch.c:38:8: error: cast to union type from type 'unsigned short' not present in union
if (((union mips16e_instruction)inst).ri.opcode
^ ~~~~
The changed code can be compiled successfully by both gcc and clang.
Signed-off-by: Toma Tabacu <toma.tabacu@imgtec.com>
Signed-off-by: Daniel Sanders <daniel.sanders@imgtec.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Andreas Herrmann <andreas.herrmann@caviumnetworks.com>
Cc: David Daney <david.daney@cavium.com>
Cc: Manuel Lauss <manuel.lauss@gmail.com>
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
---
arch/mips/kernel/branch.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/mips/kernel/branch.c b/arch/mips/kernel/branch.c
index 4d7d99d..7110963 100644
--- a/arch/mips/kernel/branch.c
+++ b/arch/mips/kernel/branch.c
@@ -35,8 +35,10 @@ int __isa_exception_epc(struct pt_regs *regs)
return epc;
}
if (cpu_has_mips16) {
- if (((union mips16e_instruction)inst).ri.opcode
- == MIPS16e_jal_op)
+ union mips16e_instruction inst_mips16e;
+
+ inst_mips16e.full = inst;
+ if (inst_mips16e.ri.opcode == MIPS16e_jal_op)
epc += 4;
else
epc += 2;
--
2.1.4
next prev parent reply other threads:[~2015-02-03 13:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-03 13:37 [PATCH 0/5] MIPS: LLVMLinux: Patches to enable compilation of a working kernel for MIPS using Clang/LLVM Daniel Sanders
2015-02-03 13:37 ` [PATCH 1/5] LLVMLinux: Correct size_index table before replacing the bootstrap kmem_cache_node Daniel Sanders
2015-02-03 15:14 ` Christoph Lameter
2015-02-03 16:00 ` Daniel Sanders
2015-02-04 20:52 ` [PATCH v2 " Daniel Sanders
2015-02-04 21:06 ` [PATCH v3 1/5] slab: " Daniel Sanders
2015-02-05 8:37 ` Pekka Enberg
2015-02-04 19:33 ` [PATCH 1/5] LLVMLinux: " Pekka Enberg
2015-02-04 20:38 ` Daniel Sanders
2015-02-04 20:42 ` Pekka Enberg
2015-02-04 21:08 ` Daniel Sanders
2015-02-03 13:37 ` Daniel Sanders [this message]
2015-02-03 13:37 ` [PATCH 3/5] MIPS: LLVMLinux: Fix an 'inline asm input/output type mismatch' error Daniel Sanders
2015-02-04 12:57 ` Maciej W. Rozycki
2015-02-05 15:43 ` Daniel Sanders
2015-02-06 10:09 ` Maciej W. Rozycki
2015-02-09 11:33 ` [PATCH v2 " Daniel Sanders
2015-02-09 14:12 ` Maciej W. Rozycki
2015-02-09 16:44 ` [PATCH v3 " Daniel Sanders
2015-02-03 13:37 ` [PATCH 4/5] MIPS: LLVMLinux: Silence variable self-assignment warnings Daniel Sanders
2015-02-03 13:37 ` [PATCH 5/5] MIPS: LLVMLinux: Silence unicode warnings when preprocessing assembly Daniel Sanders
2015-02-04 10:36 ` Maciej W. Rozycki
2015-02-05 10:25 ` Toma Tabacu
2015-02-05 12:35 ` Maciej W. Rozycki
2015-02-05 12:56 ` Måns Rullgård
2015-02-11 17:37 ` Daniel Sanders
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422970639-7922-3-git-send-email-daniel.sanders@imgtec.com \
--to=daniel.sanders@imgtec.com \
--cc=andreas.herrmann@caviumnetworks.com \
--cc=david.daney@cavium.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=manuel.lauss@gmail.com \
--cc=ralf@linux-mips.org \
--cc=toma.tabacu@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®