From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755877AbbBCN4W (ORCPT ); Tue, 3 Feb 2015 08:56:22 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:38580 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752787AbbBCN4U (ORCPT ); Tue, 3 Feb 2015 08:56:20 -0500 From: Sasha Levin To: linux-kernel@vger.kernel.org Cc: Sasha Levin , Chien Yen , "David S. Miller" , rds-devel@oss.oracle.com (moderated list:RDS - RELIABLE DA...), netdev@vger.kernel.org (open list:NETWORKING [GENERAL]) Subject: [PATCH] net: rds: use correct size for max unacked packets and bytes Date: Tue, 3 Feb 2015 08:55:58 -0500 Message-Id: <1422971760-8217-1-git-send-email-sasha.levin@oracle.com> X-Mailer: git-send-email 2.1.0 X-Source-IP: ucsinet21.oracle.com [156.151.31.93] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Max unacked packets/bytes is an int while sizeof(long) was used in the sysctl table. This means that when they were getting read we'd also leak kernel memory to userspace along with the timeout values. Signed-off-by: Sasha Levin --- net/rds/sysctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/rds/sysctl.c b/net/rds/sysctl.c index c3b0cd4..c173f69 100644 --- a/net/rds/sysctl.c +++ b/net/rds/sysctl.c @@ -71,14 +71,14 @@ static struct ctl_table rds_sysctl_rds_table[] = { { .procname = "max_unacked_packets", .data = &rds_sysctl_max_unacked_packets, - .maxlen = sizeof(unsigned long), + .maxlen = sizeof(int), .mode = 0644, .proc_handler = proc_dointvec, }, { .procname = "max_unacked_bytes", .data = &rds_sysctl_max_unacked_bytes, - .maxlen = sizeof(unsigned long), + .maxlen = sizeof(int), .mode = 0644, .proc_handler = proc_dointvec, }, -- 1.7.10.4