From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161134AbbBCUFz (ORCPT ); Tue, 3 Feb 2015 15:05:55 -0500 Received: from cpsmtpb-ews01.kpnxchange.com ([213.75.39.4]:62588 "EHLO cpsmtpb-ews01.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966715AbbBCUFx (ORCPT ); Tue, 3 Feb 2015 15:05:53 -0500 Message-ID: <1422993950.23894.16.camel@x220> Subject: [PATCH] [linux-next] sprd_serial: compile sprd_suspend and sprd_resume conditionally From: Paul Bolle To: Greg Kroah-Hartman , Jiri Slaby Cc: Valentin Rothberg , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 03 Feb 2015 21:05:50 +0100 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-OriginalArrivalTime: 03 Feb 2015 20:05:50.0518 (UTC) FILETIME=[CEA02D60:01D03FEC] X-RcptDomain: vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Building sprd_serial.o when CONFIG_PM_SLEEP is not defined triggers these warnings: drivers/tty/serial/sprd_serial.c:755:12: warning: ‘sprd_suspend’ defined but not used [-Wunused-function] static int sprd_suspend(struct device *dev) ^ drivers/tty/serial/sprd_serial.c:764:12: warning: ‘sprd_resume’ defined but not used [-Wunused-function] static int sprd_resume(struct device *dev) ^ Let's compile these functions only when CONFIG_PM_SLEEP is defined. Signed-off-by: Paul Bolle --- The only reason I looked into this driver is because it landed in today's linux-next (ie, next-20150203) and depends on ARCH_SPRD. ARCH_SPRD is not yet included in linux-next. Since there was a patch submitted on lkml recently to add that symbol that's not a big deal. (That might change if that symbol doesn't make it into v3.20-rc[123] or so.) But I did compile this file while looking into this issue. Compile tested only, on x86_64, using the hacky make drivers/tty/serial/sprd_serial.o way to compile this file! drivers/tty/serial/sprd_serial.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/tty/serial/sprd_serial.c b/drivers/tty/serial/sprd_serial.c index 594b63331ef4..be3ed3f4ad60 100644 --- a/drivers/tty/serial/sprd_serial.c +++ b/drivers/tty/serial/sprd_serial.c @@ -752,6 +752,7 @@ static int sprd_probe(struct platform_device *pdev) return ret; } +#ifdef CONFIG_PM_SLEEP static int sprd_suspend(struct device *dev) { struct sprd_uart_port *sup = dev_get_drvdata(dev); @@ -769,6 +770,7 @@ static int sprd_resume(struct device *dev) return 0; } +#endif static SIMPLE_DEV_PM_OPS(sprd_pm_ops, sprd_suspend, sprd_resume); -- 1.9.3