From: Lad Prabhakar <prabhakar.csengg@gmail.com>
To: Willem Riede <osst@riede.org>,
"James E.J. Bottomley" <JBottomley@parallels.com>
Cc: osst-users@lists.sourceforge.net, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, "Lad,
Prabhakar" <prabhakar.csengg@gmail.com>
Subject: [PATCH] scsi: osst: fix sparse warnings
Date: Wed, 4 Feb 2015 18:48:05 +0000 [thread overview]
Message-ID: <1423075685-7397-1-git-send-email-prabhakar.csengg@gmail.com> (raw)
From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
this patch fixes following sparse warnings:
osst.c:5699:1: warning: symbol 'dev_attr_ADR_rev' was not declared. Should it be static?
osst.c:5713:1: warning: symbol 'dev_attr_media_version' was not declared. Should it be static?
osst.c:5726:1: warning: symbol 'dev_attr_capacity' was not declared. Should it be static?
osst.c:5740:1: warning: symbol 'dev_attr_BOT_frame' was not declared. Should it be static?
osst.c:5754:1: warning: symbol 'dev_attr_EOD_frame' was not declared. Should it be static?
osst.c:5767:1: warning: symbol 'dev_attr_file_count' was not declared. Should it be static?
Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
---
Found this issue on linux-next (gcc version 4.8.2,
sparse version 0.4.5-rc1)and applies on top linux-next.
drivers/scsi/osst.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/osst.c b/drivers/scsi/osst.c
index 5033223..4c100bf 100644
--- a/drivers/scsi/osst.c
+++ b/drivers/scsi/osst.c
@@ -5696,7 +5696,7 @@ static ssize_t osst_adr_rev_show(struct device *dev,
return l;
}
-DEVICE_ATTR(ADR_rev, S_IRUGO, osst_adr_rev_show, NULL);
+static DEVICE_ATTR(ADR_rev, S_IRUGO, osst_adr_rev_show, NULL);
static ssize_t osst_linux_media_version_show(struct device *dev,
struct device_attribute *attr,
@@ -5710,7 +5710,7 @@ static ssize_t osst_linux_media_version_show(struct device *dev,
return l;
}
-DEVICE_ATTR(media_version, S_IRUGO, osst_linux_media_version_show, NULL);
+static DEVICE_ATTR(media_version, S_IRUGO, osst_linux_media_version_show, NULL);
static ssize_t osst_capacity_show(struct device *dev,
struct device_attribute *attr, char *buf)
@@ -5723,7 +5723,7 @@ static ssize_t osst_capacity_show(struct device *dev,
return l;
}
-DEVICE_ATTR(capacity, S_IRUGO, osst_capacity_show, NULL);
+static DEVICE_ATTR(capacity, S_IRUGO, osst_capacity_show, NULL);
static ssize_t osst_first_data_ppos_show(struct device *dev,
struct device_attribute *attr,
@@ -5737,7 +5737,7 @@ static ssize_t osst_first_data_ppos_show(struct device *dev,
return l;
}
-DEVICE_ATTR(BOT_frame, S_IRUGO, osst_first_data_ppos_show, NULL);
+static DEVICE_ATTR(BOT_frame, S_IRUGO, osst_first_data_ppos_show, NULL);
static ssize_t osst_eod_frame_ppos_show(struct device *dev,
struct device_attribute *attr,
@@ -5751,7 +5751,7 @@ static ssize_t osst_eod_frame_ppos_show(struct device *dev,
return l;
}
-DEVICE_ATTR(EOD_frame, S_IRUGO, osst_eod_frame_ppos_show, NULL);
+static DEVICE_ATTR(EOD_frame, S_IRUGO, osst_eod_frame_ppos_show, NULL);
static ssize_t osst_filemark_cnt_show(struct device *dev,
struct device_attribute *attr, char *buf)
@@ -5764,7 +5764,7 @@ static ssize_t osst_filemark_cnt_show(struct device *dev,
return l;
}
-DEVICE_ATTR(file_count, S_IRUGO, osst_filemark_cnt_show, NULL);
+static DEVICE_ATTR(file_count, S_IRUGO, osst_filemark_cnt_show, NULL);
static struct class *osst_sysfs_class;
--
1.9.1
reply other threads:[~2015-02-04 18:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423075685-7397-1-git-send-email-prabhakar.csengg@gmail.com \
--to=prabhakar.csengg@gmail.com \
--cc=JBottomley@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=osst-users@lists.sourceforge.net \
--cc=osst@riede.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®