From: David Howells <dhowells@redhat.com>
To: Juerg Haefliger <juerg.haefliger@hpe.com>
Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org,
keyrings@vger.kernel.org, dwmw2@infradead.org
Subject: Re: [PATCH] scripts/sign-file.c: Add support for signing with a raw signature
Date: Wed, 03 Feb 2016 20:45:31 +0000 [thread overview]
Message-ID: <14231.1454532331@warthog.procyon.org.uk> (raw)
In-Reply-To: <1454145497-4567-1-git-send-email-juerg.haefliger@hpe.com>
In the patched file, I see:
if (!raw_sig) {
...
}
if (!raw_sig && save_sig) {
...
}
if (!raw_sig && sign_only) {
...
}
Can you just merge the three into one if-statement that is conditional on
!raw_sig with conditional bits inside? It might be worth moving the contents
out to its own function, but it deals with sufficient of main's context that
it might not actually be worthwhile.
David
next prev parent reply other threads:[~2016-02-03 20:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-30 9:18 Juerg Haefliger
2016-02-03 20:34 ` David Howells
2016-02-04 9:07 ` Juerg Haefliger
2016-02-04 10:42 ` David Howells
2016-02-03 20:45 ` David Howells [this message]
2016-02-04 11:09 ` [PATCH v2] " Juerg Haefliger
2016-02-09 16:44 ` David Howells
2016-02-10 10:12 ` David Howells
2016-02-10 10:25 ` David Woodhouse
2016-02-10 13:07 ` Juerg Haefliger
2016-02-10 13:24 ` Juerg Haefliger
2016-02-18 9:26 ` Juerg Haefliger
2016-02-18 17:23 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14231.1454532331@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=juerg.haefliger@hpe.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome