From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Kashyap Desai <kashyap.desai@avagotech.com>,
Sumit Saxena <sumit.saxena@avagotech.com>,
Uday Lingala <uday.lingala@avagotech.com>,
"James E.J. Bottomley" <JBottomley@parallels.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
megaraidlinux.pdl@avagotech.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] scsi: megaraid_sas: Prevent future %p disaster
Date: Fri, 6 Feb 2015 15:33:41 +0100 [thread overview]
Message-ID: <1423233221-27069-1-git-send-email-linux@rasmusvillemoes.dk> (raw)
There is currently no %po format extension, so currently the letters
"on" are simply skipped and the pointer is printed as expected (while
missing the word on). However, it is probably only a matter of time
before someone comes up with a %po extension, at which point this is
likely to fail spectacularly.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index ff283d23788a..e7c6b9c946d6 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -3105,7 +3105,7 @@ megasas_internal_reset_defer_cmds(struct megasas_instance *instance)
for (i = 0; i < max_cmd; i++) {
cmd = instance->cmd_list[i];
if (cmd->sync_cmd == 1 || cmd->scmd) {
- printk(KERN_NOTICE "megasas: moving cmd[%d]:%p:%d:%p"
+ printk(KERN_NOTICE "megasas: moving cmd[%d]:%p:%d:%p "
"on the defer queue as internal\n",
defer_index, cmd, cmd->sync_cmd, cmd->scmd);
--
2.1.3
next reply other threads:[~2015-02-06 14:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 14:33 Rasmus Villemoes [this message]
2015-02-10 16:46 ` Kashyap Desai
2015-02-10 16:55 ` Joe Perches
2015-02-10 18:38 ` Joe Perches
2015-05-12 14:04 ` Rasmus Villemoes
2015-05-12 14:52 ` Joe Perches
2015-05-12 15:01 ` Joe Perches
[not found] <OF651E5409.7FC1198E-ONC1257E49.0034C44E-C1257E49.0034D9A0@de.ibm.com>
2015-05-18 10:05 ` Ursula Braun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423233221-27069-1-git-send-email-linux@rasmusvillemoes.dk \
--to=linux@rasmusvillemoes.dk \
--cc=JBottomley@parallels.com \
--cc=kashyap.desai@avagotech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=megaraidlinux.pdl@avagotech.com \
--cc=sumit.saxena@avagotech.com \
--cc=uday.lingala@avagotech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®