From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Huang Ying <ying.huang@intel.com>
Cc: linux-kernel@vger.kernel.org,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Paul McKenney <paulmck@linux.vnet.ibm.com>,
David Howells <dhowells@redhat.com>,
Pranith Kumar <bobby.prani@gmail.com>,
stable@vger.kernel.org
Subject: [PATCH] llist: Fix missing lockless_dereference()
Date: Fri, 6 Feb 2015 21:08:21 -0500 [thread overview]
Message-ID: <1423274934-10625-1-git-send-email-mathieu.desnoyers@efficios.com> (raw)
A lockless_dereference() appears to be missing in llist_del_first().
It should only matter for Alpha in practice.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
CC: Huang Ying <ying.huang@intel.com>
CC: Paul McKenney <paulmck@linux.vnet.ibm.com>
CC: David Howells <dhowells@redhat.com>
CC: Pranith Kumar <bobby.prani@gmail.com>
CC: stable@vger.kernel.org # v3.1+
---
lib/llist.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/lib/llist.c b/lib/llist.c
index f76196d..f34e176 100644
--- a/lib/llist.c
+++ b/lib/llist.c
@@ -26,6 +26,7 @@
#include <linux/export.h>
#include <linux/interrupt.h>
#include <linux/llist.h>
+#include <linux/rcupdate.h>
/**
@@ -67,7 +68,12 @@ struct llist_node *llist_del_first(struct llist_head *head)
{
struct llist_node *entry, *old_entry, *next;
- entry = head->first;
+ /*
+ * Load entry before entry->next. Matches the implicit
+ * memory barrier before the cmpxchg in llist_add_batch(),
+ * which ensures entry->next is stored before entry.
+ */
+ entry = lockless_dereference(head->first);
for (;;) {
if (entry == NULL)
return NULL;
--
2.1.4
next reply other threads:[~2015-02-07 2:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-07 2:08 Mathieu Desnoyers [this message]
2015-02-07 22:16 ` Greg KH
2015-02-07 22:30 ` Mathieu Desnoyers
2015-02-08 0:18 ` Matt Turner
2015-02-08 0:29 ` Greg KH
2015-02-08 0:47 ` Michael Cree
2015-02-08 0:59 ` Greg KH
2015-02-08 1:12 ` Michael Cree
2015-02-08 1:20 ` Greg KH
2015-02-08 4:25 ` Mathieu Desnoyers
2015-02-10 1:52 ` Huang Ying
2015-02-10 3:42 ` Mathieu Desnoyers
2015-02-10 9:30 ` Michael Cree
2015-02-08 0:09 ` Paul E. McKenney
2015-02-10 14:03 ` Peter Hurley
2015-02-10 16:38 ` Paul E. McKenney
2015-02-10 17:29 ` Peter Hurley
2015-02-10 18:03 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423274934-10625-1-git-send-email-mathieu.desnoyers@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=bobby.prani@gmail.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=stable@vger.kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®