From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752759AbbBHCQh (ORCPT ); Sat, 7 Feb 2015 21:16:37 -0500 Received: from mail-ie0-f194.google.com ([209.85.223.194]:36080 "EHLO mail-ie0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751611AbbBHCQg (ORCPT ); Sat, 7 Feb 2015 21:16:36 -0500 From: Frederic Jacob To: gregkh@linuxfoundation.org Cc: thomas.petazzoni@free-electrons.com, noralf@tronnes.org, linux-kernel@vger.kernel.org, Frederic Jacob Subject: [PATCH v2] Staging: fbtft: Fix Sparse warnings Date: Sat, 7 Feb 2015 21:15:25 -0500 Message-Id: <1423361725-7201-1-git-send-email-frederic.jacob.78@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <20150207091207.GB907@kroah.com> References: <20150207091207.GB907@kroah.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This fixes the folowing sparse warnings: fb_hx8340bn.c:111:6: warning: symbol 'set_addr_win' was not declared. Should it be static? fbtft_device.c:32:19: warning: symbol 'spi_device' was not declared. Should it be static? fbtft_device.c:33:24: warning: symbol 'p_device' was not declared. Should it be static? Signed-off-by: Frederic Jacob --- Corrected the changelog to specify the fixed Sparse warnings. drivers/staging/fbtft/fb_hx8340bn.c | 2 +- drivers/staging/fbtft/fbtft_device.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/fbtft/fb_hx8340bn.c b/drivers/staging/fbtft/fb_hx8340bn.c index 3939502..26a987a 100644 --- a/drivers/staging/fbtft/fb_hx8340bn.c +++ b/drivers/staging/fbtft/fb_hx8340bn.c @@ -108,7 +108,7 @@ static int init_display(struct fbtft_par *par) return 0; } -void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye) +static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye) { fbtft_par_dbg(DEBUG_SET_ADDR_WIN, par, "%s(xs=%d, ys=%d, xe=%d, ye=%d)\n", __func__, xs, ys, xe, ye); diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_device.c index b9f4c30..157f79c 100644 --- a/drivers/staging/fbtft/fbtft_device.c +++ b/drivers/staging/fbtft/fbtft_device.c @@ -29,8 +29,8 @@ #define MAX_GPIOS 32 -struct spi_device *spi_device; -struct platform_device *p_device; +static struct spi_device *spi_device; +static struct platform_device *p_device; static char *name; module_param(name, charp, 0); -- 1.9.1