From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760884AbbBIQ3h (ORCPT ); Mon, 9 Feb 2015 11:29:37 -0500 Received: from smtprelay0065.hostedemail.com ([216.40.44.65]:38645 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1760105AbbBIQ3g (ORCPT ); Mon, 9 Feb 2015 11:29:36 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3350:3622:3865:3866:3867:3870:4321:5007:6261:10004:10400:10848:11026:11232:11473:11657:11658:11914:12043:12296:12438:12517:12519:12740:13019:13069:13255:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: jelly04_3656dea706c04 X-Filterd-Recvd-Size: 1820 Message-ID: <1423499369.2933.18.camel@perches.com> Subject: Re: [PATCH] staging: lustre: lnet: lnet: lip-ptl:fix sparse warning of static declaration From: Joe Perches To: Mohammad Jamal Cc: oleg.drokin@intel.com, andreas.dilger@intel.com, gregkh@linuxfoundation.org, sudipm.mukherjee@gmail.com, devel@driverdev.osuosl.org, HPDD-discuss@ml01.01.org, linux-kernel@vger.kernel.org Date: Mon, 09 Feb 2015 08:29:29 -0800 In-Reply-To: <1423498556-18703-1-git-send-email-md.jamalmohiuddin@gmail.com> References: <1423498556-18703-1-git-send-email-md.jamalmohiuddin@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.7-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-02-09 at 21:45 +0530, Mohammad Jamal wrote: > This patch adds a static keyword to variable portal_rotor to > suppress the sparse warning of static declaration Do please compile the subsystem before sending patches. > diff --git a/drivers/staging/lustre/lnet/lnet/lib-ptl.c b/drivers/staging/lustre/lnet/lnet/lib-ptl.c [] > @@ -39,7 +39,7 @@ > #include "../../include/linux/lnet/lib-lnet.h" > > /* NB: add /proc interfaces in upcoming patches */ > -int portal_rotor = LNET_PTL_ROTOR_HASH_RT; > +static int portal_rotor = LNET_PTL_ROTOR_HASH_RT; > module_param(portal_rotor, int, 0644); > MODULE_PARM_DESC(portal_rotor, "redirect PUTs to different cpu-partitions"); $ git grep -w portal_rotor ... drivers/staging/lustre/lnet/lnet/router_proc.c:extern int portal_rotor;