mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: He Kuang <hekuang@huawei.com>
To: <namhyung@kernel.org>
Cc: <mingo@redhat.com>, <wangnan0@huawei.com>,
	<linux-kernel@vger.kernel.org>
Subject: [PATCH v2] perf: fix building error in x86_64
Date: Fri, 13 Feb 2015 15:11:14 +0800	[thread overview]
Message-ID: <1423811474-13266-1-git-send-email-hekuang@huawei.com> (raw)
In-Reply-To: <20150213053106.GH30788@sejong>

When build with ARCH=x86_64, perf failed to compile with following error:

tests/builtin-test.o:(.data+0x158): undefined reference to `test__perf_time_to_tsc'
collect2: error: ld returned 1 exit status
Makefile.perf:632: recipe for target 'perf' failed
...

Which is caused commit c6e5e9fbc3ea1 ("perf tools: Fix building error
in x86_64 when dwarf unwind is on"), ARCH test in Makefile.perf
conflicts with tests/builtin-test.c's __x86_64__.
To x86/x86_64 platform, ARCH should always override to x86 while
IS_64_BIT stands for the actual architecture.

Signed-off-by: He Kuang <hekuang@huawei.com>
---
 tools/perf/config/Makefile.arch | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tools/perf/config/Makefile.arch b/tools/perf/config/Makefile.arch
index ff95a68..836ba44 100644
--- a/tools/perf/config/Makefile.arch
+++ b/tools/perf/config/Makefile.arch
@@ -29,3 +29,7 @@ ifeq ($(LP64), 1)
 else
   IS_64_BIT := 0
 endif
+
+ifeq ($(ARCH), x86_64)
+  override ARCH := x86
+endif
-- 
2.2.0.33.gc18b867


  reply	other threads:[~2015-02-13  7:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-11  2:01 [PATCH] " He Kuang
2015-02-12  8:07 ` Namhyung Kim
2015-02-12  8:56   ` Hekuang
2015-02-13  5:31     ` Namhyung Kim
2015-02-13  7:11       ` He Kuang [this message]
2015-02-19 10:56         ` [PATCH v2] " Aaro Koskinen
2015-02-27 10:05           ` [PATCH] perf: fix building error He Kuang
2015-02-28  2:49             ` Namhyung Kim
2015-02-28  9:09               ` He Kuang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1423811474-13266-1-git-send-email-hekuang@huawei.com \
    --to=hekuang@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®