From: "Martin J. Bligh" <mbligh@aracnet.com>
To: Jeff Garzik <garzik@pobox.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] Fixup warning for acenic
Date: Wed, 19 Mar 2003 23:50:29 -0800 [thread overview]
Message-ID: <14240000.1048146629@[10.10.2.4]> (raw)
OK, it's war on warnings hour. Get this from acenic,
drivers/net/acenic.c:135: warning: `acenic_pci_tbl' defined but not used
And indeed it doesn't *seem* to be used (though I'm less than confident
about that) ... can we just rip it out? Or should this be wrapped in
#ifdef MODULE or something (I'm compiling it in)?
M.
diff -urpN -X /home/fletch/.diff.exclude virgin/drivers/net/acenic.c acenic_fix/drivers/net/acenic.c
--- virgin/drivers/net/acenic.c Wed Mar 5 07:37:02 2003
+++ acenic_fix/drivers/net/acenic.c Wed Mar 19 23:44:28 2003
@@ -131,34 +131,6 @@
#define PCI_DEVICE_ID_SGI_ACENIC 0x0009
#endif
-#if LINUX_VERSION_CODE >= 0x20400
-static struct pci_device_id acenic_pci_tbl[] __initdata = {
- { PCI_VENDOR_ID_ALTEON, PCI_DEVICE_ID_ALTEON_ACENIC_FIBRE,
- PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_NETWORK_ETHERNET << 8, 0xffff00, },
- { PCI_VENDOR_ID_ALTEON, PCI_DEVICE_ID_ALTEON_ACENIC_COPPER,
- PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_NETWORK_ETHERNET << 8, 0xffff00, },
- { PCI_VENDOR_ID_3COM, PCI_DEVICE_ID_3COM_3C985,
- PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_NETWORK_ETHERNET << 8, 0xffff00, },
- { PCI_VENDOR_ID_NETGEAR, PCI_DEVICE_ID_NETGEAR_GA620,
- PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_NETWORK_ETHERNET << 8, 0xffff00, },
- { PCI_VENDOR_ID_NETGEAR, PCI_DEVICE_ID_NETGEAR_GA620T,
- PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_NETWORK_ETHERNET << 8, 0xffff00, },
- /*
- * Farallon used the DEC vendor ID on their cards incorrectly,
- * then later Alteon's ID.
- */
- { PCI_VENDOR_ID_DEC, PCI_DEVICE_ID_FARALLON_PN9000SX,
- PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_NETWORK_ETHERNET << 8, 0xffff00, },
- { PCI_VENDOR_ID_ALTEON, PCI_DEVICE_ID_FARALLON_PN9100T,
- PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_NETWORK_ETHERNET << 8, 0xffff00, },
- { PCI_VENDOR_ID_SGI, PCI_DEVICE_ID_SGI_ACENIC,
- PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_NETWORK_ETHERNET << 8, 0xffff00, },
- { }
-};
-MODULE_DEVICE_TABLE(pci, acenic_pci_tbl);
-#endif
-
-
#ifndef MODULE_LICENSE
#define MODULE_LICENSE(a)
#endif
next reply other threads:[~2003-03-20 7:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-20 7:50 Martin J. Bligh [this message]
2003-03-20 15:47 ` Jes Sorensen
2003-03-20 16:04 ` Christoph Hellwig
2003-03-20 16:11 ` Martin J. Bligh
2003-03-20 19:20 ` Greg KH
2003-03-20 19:13 ` Martin J. Bligh
2003-03-20 19:28 ` Jeff Garzik
2003-03-20 19:30 ` Greg KH
2003-03-20 15:17 Matthew Wilcox
2003-03-20 15:50 ` Martin J. Bligh
2003-03-20 15:59 ` Matthew Wilcox
2003-03-20 16:10 ` Martin J. Bligh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='14240000.1048146629@[10.10.2.4]' \
--to=mbligh@aracnet.com \
--cc=garzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®