From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754749AbbBRAcF (ORCPT ); Tue, 17 Feb 2015 19:32:05 -0500 Received: from 216-82-208-22.static.grandenetworks.net ([216.82.208.22]:39921 "EHLO mx1.mthode.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751356AbbBRAcD (ORCPT ); Tue, 17 Feb 2015 19:32:03 -0500 From: Matthew Thode To: davem@davemloft.net Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Matthew Thode Subject: [PATCH] reject creation of netdev names with colons Date: Tue, 17 Feb 2015 18:31:57 -0600 Message-Id: <1424219517-9386-1-git-send-email-mthode@mthode.org> X-Mailer: git-send-email 2.0.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org colons are used as a separator in netdev device lookup in dev_ioctl.c Specific functions are SIOCGIFTXQLEN SIOCETHTOOL SIOCSIFNAME Signed-off-by: Matthew Thode --- net/core/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/dev.c b/net/core/dev.c index d030575..efbad386 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -946,7 +946,7 @@ bool dev_valid_name(const char *name) return false; while (*name) { - if (*name == '/' || isspace(*name)) + if (*name == '/' || *name == ':' || isspace(*name)) return false; name++; } -- 2.0.5