From: David Ahern <david.ahern@oracle.com>
To: acme@kernel.org, linux-kernel@vger.kernel.org
Cc: David Ahern <david.ahern@oracle.com>
Subject: [PATCH] perf: Compare JOBS to 0 after grep
Date: Wed, 18 Feb 2015 18:59:31 -0500 [thread overview]
Message-ID: <1424303971-91904-1-git-send-email-david.ahern@oracle.com> (raw)
If JOBS is not by user perf tries to autodetect the number by grepping the
number of CPUs from /proc/cpuinfo. 'grep -c' will always return an integer
so after this command JOBS should be compared to 0, not "".
Signed-off-by: David Ahern <david.ahern@oracle.com>
---
tools/perf/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index cb2e5868c8e8..d5020aeb5626 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -25,7 +25,7 @@ unexport MAKEFLAGS
#
ifeq ($(JOBS),)
JOBS := $(shell grep -c ^processor /proc/cpuinfo 2>/dev/null)
- ifeq ($(JOBS),)
+ ifeq ($(JOBS),0)
JOBS := 1
endif
endif
--
1.9.3
next reply other threads:[~2015-02-19 0:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 23:59 David Ahern [this message]
2015-03-03 6:21 ` [tip:perf/core] perf tools: " tip-bot for David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424303971-91904-1-git-send-email-david.ahern@oracle.com \
--to=david.ahern@oracle.com \
--cc=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome