From: Tolga Ceylan <tolga.ceylan@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Christoph Hellwig <hch@infradead.org>,
Hannes Reinecke <hare@suse.de>, Ewan Milne <emilne@redhat.com>,
Alan Cox <alan@linux.intel.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
tolga.ceylan@gmail.com
Subject: [PATCH 1/1] Staging: i2o: i2o_scsi: Fixed coding style issue
Date: Wed, 18 Feb 2015 16:45:50 -0800 [thread overview]
Message-ID: <1424306750-27230-1-git-send-email-tolga.ceylan@gmail.com> (raw)
Removed assignment in if condition
Signed-off-by: Tolga Ceylan <tolga.ceylan@gmail.com>
---
drivers/staging/i2o/i2o_scsi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/i2o/i2o_scsi.c b/drivers/staging/i2o/i2o_scsi.c
index 1b11dcb..f320366 100644
--- a/drivers/staging/i2o/i2o_scsi.c
+++ b/drivers/staging/i2o/i2o_scsi.c
@@ -750,7 +750,8 @@ static int i2o_scsi_bios_param(struct scsi_device *sdev,
size = capacity;
ip[0] = 64; /* heads */
ip[1] = 32; /* sectors */
- if ((ip[2] = size >> 11) > 1024) { /* cylinders, test for big disk */
+ ip[2] = size >> 11;
+ if (ip[2] > 1024) { /* cylinders, test for big disk */
ip[0] = 255; /* heads */
ip[1] = 63; /* sectors */
ip[2] = size / (255 * 63); /* cylinders */
--
2.3.0
next reply other threads:[~2015-02-19 0:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-19 0:45 Tolga Ceylan [this message]
2015-02-19 6:28 ` Dan Carpenter
2015-02-19 6:31 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424306750-27230-1-git-send-email-tolga.ceylan@gmail.com \
--to=tolga.ceylan@gmail.com \
--cc=alan@linux.intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=emilne@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®