From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755286AbbBSA6n (ORCPT ); Wed, 18 Feb 2015 19:58:43 -0500 Received: from ozlabs.org ([103.22.144.67]:40064 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754110AbbBSA6m (ORCPT ); Wed, 18 Feb 2015 19:58:42 -0500 Message-ID: <1424307520.22020.5.camel@ellerman.id.au> Subject: Re: [PATCH 4/4] powerpc/mpic: remove unused functions From: Michael Ellerman To: Arseny Solokha Cc: Benjamin Herrenschmidt , Paul Mackerras , Scott Wood , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Date: Thu, 19 Feb 2015 11:58:40 +1100 In-Reply-To: <1424084188-17097-5-git-send-email-asolokha@kb.kras.ru> References: <1424084188-17097-1-git-send-email-asolokha@kb.kras.ru> <1424084188-17097-5-git-send-email-asolokha@kb.kras.ru> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.7-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-02-16 at 17:56 +0700, Arseny Solokha wrote: > Drop unused fsl_mpic_primary_get_version(), mpic_set_clk_ratio(), > mpic_set_serial_int(). I'm always happy to remove unused code, but the interesting question is why are they unused? Please tell me in the changelog. cheers