mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adrien Schildknecht <adrien+dev@schischi.me>
To: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	x86@kernel.org, rostedt@goodmis.org, heukelum@fastmail.fm,
	luto@amacapital.net, adech.fo@gmail.com,
	masami.hiramatsu.pt@hitachi.com, akpm@linux-foundation.org,
	a.ryabinin@samsung.com, fruggeri@arista.com
Cc: linux-kernel@vger.kernel.org,
	Adrien Schildknecht <adrien+dev@schischi.me>
Subject: [PATCH 2/2] x86: fix output of show_trace_log_lvl()
Date: Thu, 19 Feb 2015 23:43:16 +0100	[thread overview]
Message-ID: <1424385796-28910-3-git-send-email-adrien+dev@schischi.me> (raw)
In-Reply-To: <1424385796-28910-1-git-send-email-adrien+dev@schischi.me>

Prepend the log level in printk_stack_address.
Using printk with just a log level is ignored and thus has no effect on
the next pr_cont.

Signed-off-by: Adrien Schildknecht <adrien+dev@schischi.me>
---
 arch/x86/kernel/dumpstack.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c
index cf3df1d..da1ab6a 100644
--- a/arch/x86/kernel/dumpstack.c
+++ b/arch/x86/kernel/dumpstack.c
@@ -25,10 +25,12 @@ unsigned int code_bytes = 64;
 int kstack_depth_to_print = 3 * STACKSLOTS_PER_LINE;
 static int die_counter;
 
-static void printk_stack_address(unsigned long address, int reliable)
+static void printk_stack_address(unsigned long address, int reliable,
+		void *data)
 {
-	pr_cont(" [<%p>] %s%pB\n",
-		(void *)address, reliable ? "" : "? ", (void *)address);
+	pr_cont("%s [<%p>] %s%pB\n",
+		(char *)data, (void *)address, reliable ? "" : "? ",
+		(void *)address);
 }
 
 void printk_address(unsigned long address)
@@ -155,8 +157,7 @@ static int print_trace_stack(void *data, char *name)
 static void print_trace_address(void *data, unsigned long addr, int reliable)
 {
 	touch_nmi_watchdog();
-	printk(data);
-	printk_stack_address(addr, reliable);
+	printk_stack_address(addr, reliable, data);
 }
 
 static const struct stacktrace_ops print_trace_ops = {
-- 
2.2.1


  parent reply	other threads:[~2015-02-19 22:44 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-19 22:43 [PATCH 0/2] x86: fix output of show_stack_log_lvl Adrien Schildknecht
2015-02-19 22:43 ` [PATCH 1/2] x86: fix output of show_stack_log_lvl() Adrien Schildknecht
2015-02-20  0:06   ` Borislav Petkov
2015-02-19 22:43 ` Adrien Schildknecht [this message]
2015-02-20  2:34 ` [PATCH v2] " Adrien Schildknecht
2015-02-20  4:45   ` Steven Rostedt
     [not found]     ` <CA+55aFzDt_7Rs9=4XFKo0LP4iBnV4qmJWUDACtBDbV4eRE-X9A@mail.gmail.com>
2015-02-20 17:05       ` Steven Rostedt
2015-02-20 17:35         ` Borislav Petkov
2015-02-20 17:40         ` Joe Perches
     [not found]           ` <CA+55aFx8pcoGzKuTubwzcBc-0=_Eoiu2n=Ub75PDuo8GkZvyng@mail.gmail.com>
2015-02-20 18:03             ` Joe Perches
2015-02-20 18:51               ` Linus Torvalds
2015-02-20 19:15                 ` Joe Perches
2015-02-20  8:10   ` Ingo Molnar
2015-02-20 10:38     ` Borislav Petkov
2015-02-20 16:39       ` Adrien Schildknecht
2015-03-03 11:28   ` [tip:x86/debug] x86/kernel: Fix " tip-bot for Adrien Schildknecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1424385796-28910-3-git-send-email-adrien+dev@schischi.me \
    --to=adrien+dev@schischi.me \
    --cc=a.ryabinin@samsung.com \
    --cc=adech.fo@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=fruggeri@arista.com \
    --cc=heukelum@fastmail.fm \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome