From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754593AbbBTNNv (ORCPT ); Fri, 20 Feb 2015 08:13:51 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:56131 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754535AbbBTNNs (ORCPT ); Fri, 20 Feb 2015 08:13:48 -0500 X-AuditID: cbfec7f4-b7f126d000001e9a-c9-54e732780ec3 From: Krzysztof Kozlowski To: Cezary Jackiewicz , Darren Hart , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guenter Roeck , Matthew Garrett , Krzysztof Kozlowski , stable@vger.kernel.org Subject: [RFT PATCH v3 1/2] compal-laptop: Fix leaking hwmon device Date: Fri, 20 Feb 2015 14:13:34 +0100 Message-id: <1424438015-3006-1-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrGJMWRmVeSWpSXmKPExsVy+t/xa7oVRs9DDFb1MFksOdHNYtG10MDi 9QtDi8u75rBZPFl4hsni4ycbi9V7XjBbLNj4iNGBw2PnrLvsHptXaHksvNLM5LHzewO7R9+W VYwenzfJBbBFcdmkpOZklqUW6dslcGVsmHSTqWA3V8Wd7R8YGxgvcXQxcnJICJhI7OnrYoKw xSQu3FvP1sXIxSEksJRR4sCmNawQTh+TRNuF32wgVWwCxhKbly8BqxIRmMcoMenRVzCHWWA+ o8SE0/+YQaqEBZwlFrfeZwGxWQRUJRY3PWQHsXkF3CSWN01ng9gnJ3Hy2GTWCYzcCxgZVjGK ppYmFxQnpeca6hUn5haX5qXrJefnbmKEhM2XHYyLj1kdYhTgYFTi4f2x51mIEGtiWXFl7iFG CQ5mJRFeT4XnIUK8KYmVValF+fFFpTmpxYcYmTg4pRoYZ8w/587kxKHnvyx0ymLGLXVbyw+8 4PJssLSYKDfno4yisNKxY2dmrGCSkjn6V/ulqtzWPa33e35duhwfclH6v9XZyVevtYoWlBTW bQzZIMd1c1PFv0bRM8u3H3O9c+NrkcuBeJ+1ga33Z/r/500+/1j7IZc7Z/uSzPlME1dbcfMU CWhPV+GyVGIpzkg01GIuKk4EAE/xBJb5AQAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The commit c2be45f09bb0 ("compal-laptop: Use devm_hwmon_device_register_with_groups") wanted to change the registering of hwmon device to resource-managed version. It mostly did it except the main thing - it forgot to use devm-like function so the hwmon device leaked after device removal or probe failure. Signed-off-by: Krzysztof Kozlowski Fixes: c2be45f09bb0 ("compal-laptop: Use devm_hwmon_device_register_with_groups") Cc: --- Changes since v2: 1. None. Changes since v1: 1. New patch. --- drivers/platform/x86/compal-laptop.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/compal-laptop.c b/drivers/platform/x86/compal-laptop.c index 15c0fab2bfa1..eb9885e7fb0e 100644 --- a/drivers/platform/x86/compal-laptop.c +++ b/drivers/platform/x86/compal-laptop.c @@ -1026,9 +1026,9 @@ static int compal_probe(struct platform_device *pdev) if (err) return err; - hwmon_dev = hwmon_device_register_with_groups(&pdev->dev, - "compal", data, - compal_hwmon_groups); + hwmon_dev = devm_hwmon_device_register_with_groups(&pdev->dev, + "compal", data, + compal_hwmon_groups); if (IS_ERR(hwmon_dev)) { err = PTR_ERR(hwmon_dev); goto remove; -- 1.9.1