From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754680AbbBTNck (ORCPT ); Fri, 20 Feb 2015 08:32:40 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:57580 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754005AbbBTNcg (ORCPT ); Fri, 20 Feb 2015 08:32:36 -0500 X-AuditID: cbfec7f5-b7fc86d0000066b7-0f-54e736dd74a8 From: Krzysztof Kozlowski To: Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Milo Kim , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Dmitry Artamonow , Marek Belisko , Krzysztof Kozlowski , stable@vger.kernel.org Subject: [RFT RESEND 2/4] power_supply: ipaq_micro_battery: Fix leaking workqueue Date: Fri, 20 Feb 2015 14:32:23 +0100 Message-id: <1424439145-16895-2-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1424439145-16895-1-git-send-email-k.kozlowski@samsung.com> References: <1424439145-16895-1-git-send-email-k.kozlowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprELMWRmVeSWpSXmKPExsVy+t/xq7p3zZ6HGCxZYmQx6cl7ZouJKycz W7x+YWhxedccNovPvUcYLba3HWWx+Ld0C5vF8l/rWCxO7y6xWLDxEaMDl8fOWXfZPda8P8Xs cezaHRaPzSu0PDat6mTz6NuyitHj+I3tTB6fN8kFcERx2aSk5mSWpRbp2yVwZbQue8decIit 4ua52ewNjJdYuxg5OSQETCT2nloKZYtJXLi3nq2LkYtDSGApo8SjuVegnD4miQ3XvrKBVLEJ GEtsXr4ELCEicJ1R4srLY0wgDrPANEaJq09WgFUJCwRLbDx/h7GLkYODRUBVou2AP0iYV8Bd 4tad1UwQ6+QkTh6bDLaaU8BDonPbXDBbCKhm2dN1TBMYeRcwMqxiFE0tTS4oTkrPNdIrTswt Ls1L10vOz93ECAnHrzsYlx6zOsQowMGoxMMrcOlZiBBrYllxZe4hRgkOZiURXk+F5yFCvCmJ lVWpRfnxRaU5qcWHGJk4OKUaGEXv9tfM375J0+OZ3NR0rWkWJ+SuZhp9CFev2NG3cqGQwK51 PAmyK5nXLzoxMS3cbi33vtBtGwReZ+bddpu380aDxvbDUaUf50r/U3rKLHpjx/NlBU/nvdyq PD+d68ZNk3f++6Zt65mSe/FqW1fkgVirrUm+nNPVXyqFPVH76fSH5dMVjXNfo3YosRRnJBpq MRcVJwIAp+tm5iUCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Driver allocates singlethread workqueue in probe but it is not destroyed during removal. Signed-off-by: Krzysztof Kozlowski Fixes: 00a588f9d27f ("power: add driver for battery reading on iPaq h3xxx") Cc: --- drivers/power/ipaq_micro_battery.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/power/ipaq_micro_battery.c b/drivers/power/ipaq_micro_battery.c index 9d694605cdb7..698cf1636bb8 100644 --- a/drivers/power/ipaq_micro_battery.c +++ b/drivers/power/ipaq_micro_battery.c @@ -251,6 +251,7 @@ static int micro_batt_remove(struct platform_device *pdev) power_supply_unregister(µ_ac_power); power_supply_unregister(µ_batt_power); cancel_delayed_work_sync(&mb->update); + destroy_workqueue(mb->wq); return 0; } -- 1.9.1