From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Bastien Nocera <hadess@hadess.net>,
Darren Hart <dvhart@infradead.org>,
ibm-acpi-devel@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
Jiri Kosina <jkosina@suse.cz>
Subject: Re: [PATCH 7/7] thinkpad_acpi: use DEVICE_ATTR_* macros
Date: Mon, 23 Feb 2015 07:25:22 -0300 [thread overview]
Message-ID: <1424687122.3034736.231116061.6D0FF46D@webmail.messagingengine.com> (raw)
In-Reply-To: <1424443481.22910.19.camel@hadess.net>
On Fri, Feb 20, 2015, at 11:44, Bastien Nocera wrote:
> Use the DEVICE_ATTR_RW macro to reduce boiler plate
So far, so good, but you also used the DEVICE_ATTR_RO macro...
> and move the attribute declaration to get rid of function signatures.
I didn't see any "move the attribute declaration" done in this patch.
Other than that, looks good.
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
next prev parent reply other threads:[~2015-02-23 10:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 14:44 Bastien Nocera
2015-02-23 10:25 ` Henrique de Moraes Holschuh [this message]
2015-02-23 10:27 ` Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424687122.3034736.231116061.6D0FF46D@webmail.messagingengine.com \
--to=hmh@hmh.eng.br \
--cc=dvhart@infradead.org \
--cc=hadess@hadess.net \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®