From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752799AbbBWLsi (ORCPT ); Mon, 23 Feb 2015 06:48:38 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:49176 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752219AbbBWLs2 (ORCPT ); Mon, 23 Feb 2015 06:48:28 -0500 X-AuditID: cbfec7f4-b7f126d000001e9a-34-54eb12f50784 From: Krzysztof Kozlowski To: Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Len Brown , Jiri Kosina , David Herrmann , Cezary Jackiewicz , Darren Hart , Support Opensource , Milo Kim , Julian Andres Klode , Marc Dietrich , Greg Kroah-Hartman , linux-acpi@vger.kernel.org, linux-input@vger.kernel.org, platform-driver-x86@vger.kernel.org, patches@opensource.wolfsonmicro.com, ac100@lists.launchpad.net, linux-tegra@vger.kernel.org, devel@driverdev.osuosl.org, Linus Walleij , Samuel Ortiz , Lee Jones , linux-arm-kernel@lists.infradead.org, Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Daniel Mack , Haojian Zhuang , Robert Jarzmik Cc: Thomas Gleixner , Pavel Machek , Kyungmin Park , Marek Szyprowski , Krzysztof Kozlowski Subject: [PATCH v4 17/20] power_supply: 88pm860x_charger: Decrement the power supply's device reference counter Date: Mon, 23 Feb 2015 12:47:38 +0100 Message-id: <1424692061-30624-18-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1424692061-30624-1-git-send-email-k.kozlowski@samsung.com> References: <1424692061-30624-1-git-send-email-k.kozlowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAAy2RWUxTYRCF/e/W24bGa1m8QDBao4moLFFkBCEmPvj7YMCIxpAoVmzAyGYL KC6BgD4Alq0ISgAlRaoge6KyCFgBRVbBkCCbBNCy70QR0BZ8m3PmO3MehiUl7ygr9lpQqFwR JAuQMiKqef3j14NLkgkvh6o6O0honSUg91M8BdFr4xSkjMyQUN2yIgBNlwXE5ThA8ks1CTGa YgY6ipwhrXQ75M09ZaAqU0PBhN4RWqMnBTC41ICgYmiKgdRVLQHamkQEZcPdNPTML9PQVZnJ wIKqHkHsYgYDhfX9Aohtz0GgXSmioLPumSEx9ZeB/s8NDBRU60loae6kIWPSFJrjaWiuCoV3 D76QUF72iIRfJcP08b34xbw9Hqj5QOHEogUaV2T0C/Ds3CU8mqQW4PIXtnhkXEvjsvxYBvd1 VzN4uq1NgLObzuDarFcGIDcSNzzso/BY8h/G09JbdOyqPOBauFxh735Z5F+pWyVCik1uJS63 UVGoUBSHhCzPHebVP9bozdmC7xgoZuKQiJVwzxFf0J35XyQQfN5YLGGkGO4QX67N3ViYcY1C /n2hijAKkutE/PBIk8BImXI3+HT1t427FLeH/6k3JoSsmMN8XvIUsdm3g29qVBsYlhUa/MHX 4UZbwp3kVaWpKAmJn6Et+chcHuYborziF+hop5QFKsOC/Ox8gwPL0ObLF98iTaOLDnEskpqI v4ePe0loWbgyIlCHeJaUmomtfxss8VVZxG25IthHERYgV+oQwQqtopCHWcp5qev+U/fchwYJ 7+mjbZlrR5ycd59OX6+8/wTErVsbd0UKc7q86g5YNey7o5/p/Wju55GQEhHl8jgrpGTK3TV1 9M3ZUWHCddeCmzHttebbhvbcNXHrsValYXlJvBNq13me8A9ysnQeqjm30+2CTVWKqc/z7OlR fa/KZkWTcVFKKf1ljrakQin7B2oaSuLQAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use power_supply_put() to decrement the power supply's device reference counter. Signed-off-by: Krzysztof Kozlowski Acked-by: Pavel Machek Reviewed-by: Bartlomiej Zolnierkiewicz Reviewed-by: Sebastian Reichel --- drivers/power/88pm860x_charger.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/power/88pm860x_charger.c b/drivers/power/88pm860x_charger.c index a7f32a5b2299..bf822aa00c14 100644 --- a/drivers/power/88pm860x_charger.c +++ b/drivers/power/88pm860x_charger.c @@ -298,13 +298,18 @@ static int set_charging_fsm(struct pm860x_charger_info *info) return -EINVAL; ret = power_supply_get_property(psy, POWER_SUPPLY_PROP_VOLTAGE_NOW, &data); - if (ret) + if (ret) { + power_supply_put(psy); return ret; + } vbatt = data.intval / 1000; ret = power_supply_get_property(psy, POWER_SUPPLY_PROP_PRESENT, &data); - if (ret) + if (ret) { + power_supply_put(psy); return ret; + } + power_supply_put(psy); mutex_lock(&info->lock); info->present = data.intval; @@ -447,6 +452,7 @@ static irqreturn_t pm860x_temp_handler(int irq, void *data) set_charging_fsm(info); out: + power_supply_put(psy); return IRQ_HANDLED; } @@ -507,6 +513,7 @@ static irqreturn_t pm860x_done_handler(int irq, void *data) out: mutex_unlock(&info->lock); + power_supply_put(psy); dev_dbg(info->dev, "%s, Allowed: %d\n", __func__, info->allowed); set_charging_fsm(info); -- 1.9.1