From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932103AbbBXR7K (ORCPT ); Tue, 24 Feb 2015 12:59:10 -0500 Received: from foss.arm.com ([217.140.101.70]:34426 "EHLO usa-sjc-mx-foss1.foss.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753572AbbBXR6a (ORCPT ); Tue, 24 Feb 2015 12:58:30 -0500 From: Lorenzo Pieralisi To: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Lorenzo Pieralisi , "Rafael J. Wysocki" , Daniel Lezcano Subject: [PATCH 1/2] drivers: cpuidle: remove stale irq disabling call in cpuidle_enter_freeze() Date: Tue, 24 Feb 2015 17:58:49 +0000 Message-Id: <1424800730-32059-2-git-send-email-lorenzo.pieralisi@arm.com> X-Mailer: git-send-email 2.2.1 In-Reply-To: <1424800730-32059-1-git-send-email-lorenzo.pieralisi@arm.com> References: <1424800730-32059-1-git-send-email-lorenzo.pieralisi@arm.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On return from cpuidle_enter_freeze() irqs are re-enabled by the function caller (ie cpuidle_idle_call) in the idle loop. This patch removes a stale local_irq_disable() call and its stale comment in cpuidle_enter_freeze(), since they disagree and do not serve a useful purpose. Cc: Rafael J. Wysocki Cc: Daniel Lezcano Signed-off-by: Lorenzo Pieralisi --- drivers/cpuidle/cpuidle.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c index 4d53458..f47edc6c 100644 --- a/drivers/cpuidle/cpuidle.c +++ b/drivers/cpuidle/cpuidle.c @@ -144,9 +144,6 @@ void cpuidle_enter_freeze(void) cpuidle_enter(drv, dev, index); else arch_cpu_idle(); - - /* Interrupts are enabled again here. */ - local_irq_disable(); } /** -- 2.2.1