From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753767AbbBXTPm (ORCPT ); Tue, 24 Feb 2015 14:15:42 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:46095 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753418AbbBXTPk (ORCPT ); Tue, 24 Feb 2015 14:15:40 -0500 From: Sasha Levin To: linux-kernel@vger.kernel.org Cc: Sasha Levin , "David S. Miller" , Nicolas Dichtel , Jiri Pirko , Thomas Graf , Jamal Hadi Salim , Roopa Prabhu , Cong Wang , Daniel Borkmann , netdev@vger.kernel.org (open list:NETWORKING [GENERAL]) Subject: [PATCH] rtnetlink: avoid 0 sized arrays Date: Tue, 24 Feb 2015 14:14:35 -0500 Message-Id: <1424805277-7914-1-git-send-email-sasha.levin@oracle.com> X-Mailer: git-send-email 2.1.0 X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arrays (when not in a struct) "shall have a value greater than zero". GCC complains when it's not the case here. Fixes: ba7d49b1f0 ("rtnetlink: provide api for getting and setting slave info") Signed-off-by: Sasha Levin --- net/core/rtnetlink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index ab293a3..1385de0 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -2012,8 +2012,8 @@ replay: } if (1) { - struct nlattr *attr[ops ? ops->maxtype + 1 : 0]; - struct nlattr *slave_attr[m_ops ? m_ops->slave_maxtype + 1 : 0]; + struct nlattr *attr[ops ? ops->maxtype + 1 : 1]; + struct nlattr *slave_attr[m_ops ? m_ops->slave_maxtype + 1 : 1]; struct nlattr **data = NULL; struct nlattr **slave_data = NULL; struct net *dest_net, *link_net = NULL; -- 1.7.10.4