From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752764AbbBXVsz (ORCPT ); Tue, 24 Feb 2015 16:48:55 -0500 Received: from mga01.intel.com ([192.55.52.88]:55453 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751721AbbBXVsx (ORCPT ); Tue, 24 Feb 2015 16:48:53 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,641,1418112000"; d="scan'208";a="682875831" Message-ID: <1424814530.6833.11.camel@theros.lm.intel.com> Subject: Re: [tip:x86/asm] x86/asm: Add support for the pcommit instruction From: Ross Zwisler To: "H. Peter Anvin" Cc: Borislav Petkov , hpa@linux.intel.com, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, mingo@kernel.org, tglx@linutronix.de, linux-tip-commits@vger.kernel.org Date: Tue, 24 Feb 2015 14:48:50 -0700 In-Reply-To: <54ECF01B.1070101@zytor.com> References: <1424367448-24254-1-git-send-email-ross.zwisler@linux.intel.com> <54EBB439.3040303@zytor.com> <20150224093007.GA3575@pd.tnic> <54ECEFE2.9030107@zytor.com> <54ECF01B.1070101@zytor.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20.rez) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-02-24 at 13:41 -0800, H. Peter Anvin wrote: > On 02/24/2015 01:40 PM, H. Peter Anvin wrote: > > On 02/24/2015 01:30 AM, Borislav Petkov wrote: > >> On Mon, Feb 23, 2015 at 03:14:01PM -0800, H. Peter Anvin wrote: > >>> That may cause the same line to be flushed twice. I would suggest, > >>> instead, also removing the arithmetic on void *: > >> > >> Btw, should we hold down all those suggested usages somewhere in > >> Documentation/x86/ as commit messages are generally harder to find? > >> > > > > Yes, and commit messages can't be corrected after the fact. > > > > Either that, or perhaps even better in kerneldoc comments in the source > itself. Either sounds like a good idea to me. :) Let me know which you'd prefer and I'll get something written up. - Ross