mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Luis Henriques <luis.henriques@canonical.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] block: drop extra (and bogus) printk
Date: Thu, 26 Feb 2015 22:56:48 +0000	[thread overview]
Message-ID: <1424991408-3110-1-git-send-email-luis.henriques@canonical.com> (raw)

When setting an invalid scheduler through sysfs, two log entries will be
added.  Also, when running 'echo foo > /sys/block/DISK/queue/scheduler'
the second one will includes the extra '\n':

[10465.216944] elevator: type foo not found
[10465.216953] elevator: switch to foo
 failed

This patch simply drops the second printk().

Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
---
 block/elevator.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/block/elevator.c b/block/elevator.c
index 59794d0d38e3..0ac9ea519201 100644
--- a/block/elevator.c
+++ b/block/elevator.c
@@ -997,7 +997,6 @@ ssize_t elv_iosched_store(struct request_queue *q, const char *name,
 	if (!ret)
 		return count;
 
-	printk(KERN_ERR "elevator: switch to %s failed\n", name);
 	return ret;
 }
 
-- 
2.1.4


             reply	other threads:[~2015-02-26 22:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-26 22:56 Luis Henriques [this message]
2015-03-19 17:47 ` henrix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1424991408-3110-1-git-send-email-luis.henriques@canonical.com \
    --to=luis.henriques@canonical.com \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®