mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Valentin Rothberg <Valentin.Rothberg@lip6.fr>
To: ralf@linux-mips.org, taohl@lemote.com, chenhc@lemote.com,
	linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
	sergei.shtylyov@cogentembedded.com
Cc: Valentin Rothberg <Valentin.Rothberg@lip6.fr>
Subject: [PATCH v2] loongson-3/hpet.c: remove IRQF_DISABLED flag
Date: Fri, 27 Feb 2015 14:38:18 +0100	[thread overview]
Message-ID: <1425044298-22004-1-git-send-email-Valentin.Rothberg@lip6.fr> (raw)
In-Reply-To: <1425039262-20003-1-git-send-email-Valentin.Rothberg@lip6.fr>

The IRQF_DISABLED is a NOOP and scheduled to be removed.  According to
commit e58aa3d2d0cc (genirq: Run irq handlers with interrupts disabled)
running IRQ handlers with interrupts enabled can cause stack overflows
when the interrupt line of the issuing device is still active.

Signed-off-by: Valentin Rothberg <Valentin.Rothberg@lip6.fr>
---
v2: Add commit summary of referenced commit.
---
 arch/mips/loongson/loongson-3/hpet.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/loongson/loongson-3/hpet.c b/arch/mips/loongson/loongson-3/hpet.c
index e898d68..5c21cd3 100644
--- a/arch/mips/loongson/loongson-3/hpet.c
+++ b/arch/mips/loongson/loongson-3/hpet.c
@@ -162,7 +162,7 @@ static irqreturn_t hpet_irq_handler(int irq, void *data)
 
 static struct irqaction hpet_irq = {
 	.handler = hpet_irq_handler,
-	.flags = IRQF_DISABLED | IRQF_NOBALANCING | IRQF_TIMER,
+	.flags = IRQF_NOBALANCING | IRQF_TIMER,
 	.name = "hpet",
 };
 
-- 
1.9.1


      parent reply	other threads:[~2015-02-27 13:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-27 12:14 [PATCH] " Valentin Rothberg
2015-02-27 12:47 ` Sergei Shtylyov
2015-02-27 13:38 ` Valentin Rothberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425044298-22004-1-git-send-email-Valentin.Rothberg@lip6.fr \
    --to=valentin.rothberg@lip6.fr \
    --cc=chenhc@lemote.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=taohl@lemote.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®