From: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
To: Fabian Frederick <fabf@skynet.be>, Tejun Heo <tj@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] fix busted pr_info conversion in kernel/workqueue.c
Date: Tue, 27 May 2014 14:28:59 -0400 [thread overview]
Message-ID: <14251.1401215339@turing-police.cc.vt.edu> (raw)
(resend - first attempt ate the To: line)
commit 2d916033a318d7e763eb099c69600d5dcd1ccb6b
Author: Fabian Frederick <fabf@skynet.be>
Date: Mon May 12 13:59:35 2014 -0400
kernel/workqueue.c: pr_warning/pr_warn & printk/pr_info
This commit did an incorrect printk->pr_info conversion. If we were
converting to pr_info() we should lose the log_level parameter. The problem is
that this is called (indirectly) by show_regs_print_info(), which is called
with various log_levels (from _INFO clear to _EMERG). So we leave it as
a printk() call so the desired log_level is applied.
Not a full revert, as the other half of the patch is correct.
Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
--- linux-next/kernel/workqueue.c.dist 2014-05-26 11:18:40.155380772 -0400
+++ linux-next/kernel/workqueue.c 2014-05-27 12:07:51.464678172 -0400
@@ -4440,7 +4440,7 @@ void print_worker_info(const char *log_l
probe_kernel_read(desc, worker->desc, sizeof(desc) - 1);
if (fn || name[0] || desc[0]) {
- pr_info("%sWorkqueue: %s %pf", log_lvl, name, fn);
+ printk("%sWorkqueue: %s %pf", log_lvl, name, fn);
if (desc[0])
pr_cont(" (%s)", desc);
pr_cont("\n");
next reply other threads:[~2014-05-27 18:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 18:28 Valdis Kletnieks [this message]
2014-05-27 18:44 ` Fabian Frederick
2014-05-27 20:27 ` Valdis.Kletnieks
2014-05-28 14:22 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2014-05-27 17:25 Valdis Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14251.1401215339@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®