From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753465AbbCAQI4 (ORCPT ); Sun, 1 Mar 2015 11:08:56 -0500 Received: from mail-qa0-f54.google.com ([209.85.216.54]:34227 "EHLO mail-qa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752508AbbCAQGk (ORCPT ); Sun, 1 Mar 2015 11:06:40 -0500 From: Peter Hurley To: Greg Kroah-Hartman , Andrew Morton Cc: Jiri Slaby , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Rob Herring , Peter Hurley Subject: [PATCH v2 -next 09/13] serial: earlycon: Ignore parse_options() error code Date: Sun, 1 Mar 2015 11:05:54 -0500 Message-Id: <1425225958-17908-10-git-send-email-peter@hurleysoftware.com> X-Mailer: git-send-email 2.3.0 In-Reply-To: <1425225958-17908-1-git-send-email-peter@hurleysoftware.com> References: <1425225958-17908-1-git-send-email-peter@hurleysoftware.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Because setup_earlycon() continues to attempt console registration if an error occurred parsing the option string, the actual value of the error code from parse_options() is ignored. Signed-off-by: Peter Hurley --- drivers/tty/serial/earlycon.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/tty/serial/earlycon.c b/drivers/tty/serial/earlycon.c index 0480c8f..da5e8c8 100644 --- a/drivers/tty/serial/earlycon.c +++ b/drivers/tty/serial/earlycon.c @@ -114,9 +114,8 @@ int __init setup_earlycon(char *buf, const char *match, buf += len + 1; - err = parse_options(&early_console_dev, buf); /* On parsing error, pass the options buf to the setup function */ - if (!err) + if (!parse_options(&early_console_dev, buf)) buf = NULL; port->uartclk = BASE_BAUD * 16; -- 2.3.0