From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753492AbbCAQJN (ORCPT ); Sun, 1 Mar 2015 11:09:13 -0500 Received: from mail-qc0-f177.google.com ([209.85.216.177]:43802 "EHLO mail-qc0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752674AbbCAQGj (ORCPT ); Sun, 1 Mar 2015 11:06:39 -0500 From: Peter Hurley To: Greg Kroah-Hartman , Andrew Morton Cc: Jiri Slaby , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Rob Herring , Peter Hurley Subject: [PATCH v2 -next 08/13] serial: 8250_early: Fix setup() error code Date: Sun, 1 Mar 2015 11:05:53 -0500 Message-Id: <1425225958-17908-9-git-send-email-peter@hurleysoftware.com> X-Mailer: git-send-email 2.3.0 In-Reply-To: <1425225958-17908-1-git-send-email-peter@hurleysoftware.com> References: <1425225958-17908-1-git-send-email-peter@hurleysoftware.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If parsing failed to decode a valid uart addr, return -ENODEV instead of success. Although setup_earlycon() will detect the failure anyway (because the write() method has not been set), that behavior is not obvious and should not be relied on. Signed-off-by: Peter Hurley --- drivers/tty/serial/8250/8250_early.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/8250/8250_early.c b/drivers/tty/serial/8250/8250_early.c index 1701d00..b199c10 100644 --- a/drivers/tty/serial/8250/8250_early.c +++ b/drivers/tty/serial/8250/8250_early.c @@ -146,7 +146,7 @@ static int __init early_serial8250_setup(struct earlycon_device *device, const char *options) { if (!(device->port.membase || device->port.iobase)) - return 0; + return -ENODEV; if (!device->baud) { struct uart_port *port = &device->port; -- 2.3.0