From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753350AbbCAUOL (ORCPT ); Sun, 1 Mar 2015 15:14:11 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:42505 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751313AbbCAUOD (ORCPT ); Sun, 1 Mar 2015 15:14:03 -0500 From: Colin King To: Chris Metcalf , Joe Perches Cc: linux-kernel@vger.kernel.org Subject: [PATCH] arch: tile: fix null pointer dereference on pt_regs pointer Date: Sun, 1 Mar 2015 20:12:26 +0000 Message-Id: <1425240746-3974-1-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 2.1.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King Cppcheck reports the following issue: [arch/tile/kernel/stack.c:116]: (error) Possible null pointer dereference: p In this case, on reporting on an odd fault, p is set to NULL and immediately afterwords p is dereferenced iff !kbt->profile is false. Rather than doing this check just return NULL rather than falling through to the potential null pointer dereference (since the original intentional outcome would be to return NULL anyhow) for this odd fault case. Signed-off-by: Colin Ian King --- arch/tile/kernel/stack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/tile/kernel/stack.c b/arch/tile/kernel/stack.c index 7ff5afd..2d55c04 100644 --- a/arch/tile/kernel/stack.c +++ b/arch/tile/kernel/stack.c @@ -111,7 +111,7 @@ static struct pt_regs *valid_fault_handler(struct KBacktraceIterator* kbt) } else if (kbt->verbose) { pr_err(" (odd fault: pc %#lx, sp %#lx, ex1 %#lx?)\n", p->pc, p->sp, p->ex1); - p = NULL; + return NULL; } if (!kbt->profile || ((1ULL << p->faultnum) & QUEUED_INTERRUPTS) == 0) return p; -- 2.1.4