From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753689AbbCBEll (ORCPT ); Sun, 1 Mar 2015 23:41:41 -0500 Received: from ring0.de ([5.45.105.125]:39853 "EHLO ring0.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753771AbbCBEkB (ORCPT ); Sun, 1 Mar 2015 23:40:01 -0500 X-Spam-Report: * -0.0 NO_RELAYS Informational: message was not relayed via SMTP * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.0 NO_RECEIVED Informational: message has no Received headers From: Sebastian Reichel To: Sebastian Reichel Cc: Peter Ujfalusi , Kai Vehmanen , Pavel Machek , Pali Rohar , Aaro Koskinen , Ivaylo Dimitrov , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org Subject: [PATCH 5/9] HSI: cmt_speech: Cleanup initialisation Date: Mon, 2 Mar 2015 05:38:55 +0100 Message-Id: <1425271139-24715-6-git-send-email-sre@kernel.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1425271139-24715-1-git-send-email-sre@kernel.org> References: <1425271139-24715-1-git-send-email-sre@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Cleanup initialisation process, so that its similar to the style used in ssi_protocol driver. Signed-off-by: Sebastian Reichel --- drivers/hsi/clients/cmt_speech.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/hsi/clients/cmt_speech.c b/drivers/hsi/clients/cmt_speech.c index 6d852ea..8d9860b 100644 --- a/drivers/hsi/clients/cmt_speech.c +++ b/drivers/hsi/clients/cmt_speech.c @@ -1369,7 +1369,7 @@ static struct miscdevice cs_char_miscdev = { .fops = &cs_char_fops }; -static int __init cs_hsi_client_probe(struct device *dev) +static int cs_hsi_client_probe(struct device *dev) { int err = 0; struct hsi_client *cl = to_hsi_client(dev); @@ -1385,12 +1385,12 @@ static int __init cs_hsi_client_probe(struct device *dev) err = misc_register(&cs_char_miscdev); if (err) - dev_err(dev, "Failed to register\n"); + dev_err(dev, "Failed to register: %d\n", err); return err; } -static int __exit cs_hsi_client_remove(struct device *dev) +static int cs_hsi_client_remove(struct device *dev) { struct cs_hsi_iface *hi; @@ -1417,19 +1417,15 @@ static struct hsi_client_driver cs_hsi_driver = { static int __init cs_char_init(void) { - int err = 0; - - err = hsi_register_client_driver(&cs_hsi_driver); - if (err) - pr_err(DRIVER_NAME ": Error when registering driver %d\n", err); - - return err; + pr_info("CMT speech driver added\n"); + return hsi_register_client_driver(&cs_hsi_driver); } module_init(cs_char_init); static void __exit cs_char_exit(void) { hsi_unregister_client_driver(&cs_hsi_driver); + pr_info("CMT speech driver removed\n"); } module_exit(cs_char_exit); -- 2.1.4