From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753758AbbCBJSd (ORCPT ); Mon, 2 Mar 2015 04:18:33 -0500 Received: from down.free-electrons.com ([37.187.137.238]:51211 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750750AbbCBJSY (ORCPT ); Mon, 2 Mar 2015 04:18:24 -0500 From: Boris Brezillon To: Thomas Gleixner , Jason Cooper , Peter Zijlstra , Mark Rutland , "Rafael J. Wysocki" Cc: Len Brown , Pavel Machek , linux-pm@vger.kernel.org, Wim Van Sebroeck , linux-watchdog@vger.kernel.org, Alessandro Zummo , rtc-linux@googlegroups.com, Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, Mike Turquette , linux-kernel@vger.kernel.org, Nicolas Ferre , Jean-Christophe Plagniol-Villard , Alexandre Belloni , linux-arm-kernel@lists.infradead.org, Boris Brezillon Subject: [PATCH v2 0/6] ARM: at91: fix irq_pm_install_action WARNING Date: Mon, 2 Mar 2015 10:18:12 +0100 Message-Id: <1425287898-15093-1-git-send-email-boris.brezillon@free-electrons.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org My apologies to those of you who already received this series, but I didn't increment the patch version and forgot some subsystem maintainers and MLs. Commit cab303be91dc47942bc25de33dc1140123540800 [1] introduced a WARN_ON test which triggers a WARNING backtrace on at91 platforms. While this WARN_ON is absolutely necessary to warn users that they should not mix request with and without IRQF_NO_SUSPEND flags on shared IRQs, there is no easy way to solve this issue on at91 platforms. The main reason is that the init timer is often using a shared irq line and thus request this irq with IRQF_NO_SUSPEND flag set, while other peripherals request the same irq line without this flag. This problem has recently been addressed by this patch [2] which adds a new IRQF_COND_SUSPEND flag, that authorize mixing IRQF_NO_SUSPEND and !IRQF_NO_SUSPEND as long as irq handlers setting IRQF_COND_SUSPEND can safely be called in suspended state. Doing this also implies taking care of system wakeup in devices handlers if they tag the IRQ line as a wakeup source. The first patch of this series exports the pm_system_wakeup symbol so that drivers can call pm_system_wakeup from their interrupt handler. This series then patches all at91 drivers that can have devices sharing their IRQ line with a timer. This series depends on [2]. Best Regards, Boris [1]https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/kernel/irq/pm.c?id=cab303be91dc47942bc25de33dc1140123540800 [2]https://lkml.org/lkml/2015/2/26/675 Changes since v1: - replaced the IRQF_SUSPEND_NOACTION flag by IRQF_COND_SUSPEND - properly addressed wakeup handling in drivers Boris Brezillon (6): PM / wakeup: export pm_system_wakeup symbol rtc: at91sam9: rework wakeup and interrupt handling rtc: at91rm9200: rework wakeup and interrupt handling clk: at91: implement suspend/resume for the PMC irqchip watchdog: at91sam9: request the irq with IRQF_NO_SUSPEND tty: serial: atmel: rework interrupt and wakeup handling drivers/base/power/wakeup.c | 1 + drivers/clk/at91/pmc.c | 20 ++++++++++- drivers/clk/at91/pmc.h | 1 + drivers/rtc/rtc-at91rm9200.c | 62 +++++++++++++++++++++++++-------- drivers/rtc/rtc-at91sam9.c | 73 ++++++++++++++++++++++++++++++++------- drivers/tty/serial/atmel_serial.c | 49 +++++++++++++++++++++++--- drivers/watchdog/at91sam9_wdt.c | 3 +- 7 files changed, 177 insertions(+), 32 deletions(-) -- 1.9.1