From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755393AbbCBRO5 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 2 Mar 2015 12:14:57 -0500
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:55076 "EHLO
	out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1756344AbbCBROz (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 2 Mar 2015 12:14:55 -0500
Message-Id: <1425316494.517241.234431241.0FD71073@webmail.messagingengine.com>
X-Sasl-Enc: eEudHs0VH0YfP+QKZHF5U6kVEaaNhgJDzYgdD1iFsFFF 1425316494
From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Bastien Nocera <hadess@hadess.net>, Darren Hart <dvhart@infradead.org>,
        ibm-acpi-devel@lists.sourceforge.net,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
        "linux-input" <linux-input@vger.kernel.org>,
        Jiri Kosina <jkosina@suse.cz>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain
X-Mailer: MessagingEngine.com Webmail Interface - ajax-4ba7306c
In-Reply-To: <1425303922.16791.33.camel@hadess.net>
References: <1425303922.16791.33.camel@hadess.net>
Subject: Re: [PATCH 2/4] thinkpad_acpi: Factor out get/set adaptive kbd mode
Date: Mon, 02 Mar 2015 14:14:54 -0300
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 2, 2015, at 10:45, Bastien Nocera wrote:
> Move the getting/setting of the adaptive keyboard mode to separate
> functions, so that we can reuse them later through sysfs attributes.
> 
> Signed-off-by: Bastien Nocera <hadess@hadess.net>

Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>

> ---
>  drivers/platform/x86/thinkpad_acpi.c | 61
>  ++++++++++++++++++++++--------------
>  1 file changed, 38 insertions(+), 23 deletions(-)
> 
> diff --git a/drivers/platform/x86/thinkpad_acpi.c
> b/drivers/platform/x86/thinkpad_acpi.c
> index 763aef0..5dea4c2 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -3483,6 +3483,32 @@ static const int adaptive_keyboard_modes[] = {
>  static bool adaptive_keyboard_mode_is_saved;
>  static int adaptive_keyboard_prev_mode;
>  
> +static int adaptive_keyboard_get_mode(void)
> +{
> +       int mode = 0;
> +
> +       if (!acpi_evalf(hkey_handle, &mode, "GTRW", "dd", 0)) {
> +               pr_err("Cannot read adaptive keyboard mode\n");
> +               return -EIO;
> +       }
> +
> +       return mode;
> +}
> +
> +static int adaptive_keyboard_set_mode(int new_mode)
> +{
> +       if (new_mode < 0 ||
> +               new_mode > LAYFLAT_MODE)
> +               return -EINVAL;
> +
> +       if (!acpi_evalf(hkey_handle, NULL, "STRW", "vd", new_mode)) {
> +               pr_err("Cannot set adaptive keyboard mode\n");
> +               return -EIO;
> +       }
> +
> +       return 0;
> +}
> +
>  static int adaptive_keyboard_get_next_mode(int mode)
>  {
>  	size_t i;
> @@ -3512,39 +3538,28 @@ static bool
> adaptive_keyboard_hotkey_notify_hotkey(unsigned int scancode)
>  			new_mode = adaptive_keyboard_prev_mode;
>  			adaptive_keyboard_mode_is_saved = false;
>  		} else {
> -                       if (!acpi_evalf(
> -                                       hkey_handle, &current_mode,
> -                                       "GTRW", "dd", 0)) {
> -                               pr_err("Cannot read adaptive keyboard
> mode\n");
> +                       current_mode = adaptive_keyboard_get_mode();
> +                       if (current_mode < 0)
>  				return false;
> -                       } else {
> -                               new_mode =
> adaptive_keyboard_get_next_mode(
> -                                               current_mode);
> -                       }
> +                       new_mode = adaptive_keyboard_get_next_mode(
> +                                       current_mode);
>  		}
>  
> -               if (!acpi_evalf(hkey_handle, NULL, "STRW", "vd",
> new_mode)) {
> -                       pr_err("Cannot set adaptive keyboard mode\n");
> +               if (adaptive_keyboard_set_mode(new_mode) < 0)
>  			return false;
> -               }
>  
>  		return true;
>  
>  	case DFR_SHOW_QUICKVIEW_ROW:
> -               if (!acpi_evalf(hkey_handle,
> -                               &adaptive_keyboard_prev_mode,
> -                               "GTRW", "dd", 0)) {
> -                       pr_err("Cannot read adaptive keyboard mode\n");
> +               current_mode = adaptive_keyboard_get_mode();
> +               if (current_mode < 0)
>  			return false;
> -               } else {
> -                       adaptive_keyboard_mode_is_saved = true;
>  
> -                       if (!acpi_evalf(hkey_handle,
> -                                       NULL, "STRW", "vd",
> FUNCTION_MODE)) {
> -                               pr_err("Cannot set adaptive keyboard
> mode\n");
> -                               return false;
> -                       }
> -               }
> +               adaptive_keyboard_prev_mode = current_mode;
> +               adaptive_keyboard_mode_is_saved = true;
> +
> +               if (adaptive_keyboard_set_mode (FUNCTION_MODE) < 0)
> +                       return false;
>  		return true;
>  
>  	default:
> -- 
> 2.1.0
> 
> 


-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh