From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755163AbbCCA5L (ORCPT ); Mon, 2 Mar 2015 19:57:11 -0500 Received: from cpsmtpb-ews04.kpnxchange.com ([213.75.39.7]:64510 "EHLO cpsmtpb-ews04.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751949AbbCCA5J (ORCPT ); Mon, 2 Mar 2015 19:57:09 -0500 Message-ID: <1425344228.24292.140.camel@x220> Subject: Re: [PATCH] checkkconfigsymbols.py: filter reports for tools/ From: Paul Bolle To: Valentin Rothberg Cc: gregkh@linuxfoundation.org, stefan.hengelein@fau.de, linux-kernel@vger.kernel.org, rupran@einserver.de Date: Tue, 03 Mar 2015 01:57:08 +0100 In-Reply-To: <1424873723-6311-1-git-send-email-Valentin.Rothberg@lip6.fr> References: <1424873723-6311-1-git-send-email-Valentin.Rothberg@lip6.fr> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 03 Mar 2015 00:57:08.0232 (UTC) FILETIME=[F94EF080:01D0554C] X-RcptDomain: vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-02-25 at 15:15 +0100, Valentin Rothberg wrote: > @@ -46,8 +46,9 @@ def main(): > stdout = stdout[:-1] > > for gitfile in stdout.rsplit("\n"): > - if ".git" in gitfile or "ChangeLog" in gitfile or \ > - ".log" in gitfile or os.path.isdir(gitfile): > + if ".git" in gitfile or "ChangeLog" in gitfile or \ > + ".log" in gitfile or os.path.isdir(gitfile) or \ > + gitfile.startswith("tools/"): Perhaps just gitfile == "tools/perf/config/Makefile" (but I'm unsure if that's valid python)? > continue > if REGEX_FILE_KCONFIG.match(gitfile): > kconfig_files.append(gitfile) This patch was triggered by perf changes that hit next-20150225, wasn't it? If so, we might want to find out why the perf people need to use their "$(call detected,CONFIG_EXAMPLE)" hack. Especially because that hack is also used on existing Kconfig symbols (I spotted X86, X86_64, AUDIT, and NUMA). And the usage of both valid Kconfig macros and faux Kconfig macros in that hack looks odd to me. Paul Bolle