From: Valentin Rothberg <Valentin.Rothberg@lip6.fr>
To: tglx@linutronix.de, linux-kernel@vger.kernel.org
Cc: Valentin Rothberg <Valentin.Rothberg@lip6.fr>
Subject: [PATCH] request_any_context_irq(): set IRQF_ONESHOT flag to ensure IRQ request
Date: Tue, 3 Mar 2015 13:22:17 +0100 [thread overview]
Message-ID: <1425385337-21083-1-git-send-email-Valentin.Rothberg@lip6.fr> (raw)
Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
bogus threaded irq requests") threaded IRQs without a primary handler
need to be requested with IRQF_ONESHOT, otherwise the request will fail.
Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
Signed-off-by: Valentin Rothberg <Valentin.Rothberg@lip6.fr>
---
The function has been added by commit ae731f8d ("genirq: Introduce
request_any_context_irq()"), so before "Reject bogus threaded irq
requests". LXR gives me less than a dozen of references on this
function, so it's likely that this code path has not been executed for
a longer while.
---
kernel/irq/manage.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index c0a1100..76a1610 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -1597,7 +1597,8 @@ int request_any_context_irq(unsigned int irq, irq_handler_t handler,
if (irq_settings_is_nested_thread(desc)) {
ret = request_threaded_irq(irq, NULL, handler,
- flags, name, dev_id);
+ flags | IRQF_ONESHOT, name,
+ dev_id);
return !ret ? IRQC_IS_NESTED : ret;
}
--
1.9.1
reply other threads:[~2015-03-03 12:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425385337-21083-1-git-send-email-Valentin.Rothberg@lip6.fr \
--to=valentin.rothberg@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®