From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756658AbbCCMy7 (ORCPT ); Tue, 3 Mar 2015 07:54:59 -0500 Received: from mailserver04.net.ipp.pt ([193.136.58.124]:65010 "EHLO mailserver04.net.ipp.pt" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755160AbbCCMy5 (ORCPT ); Tue, 3 Mar 2015 07:54:57 -0500 X-AuditID: c1883a7c-f799e6d000001238-7e-54f5af1ea965 From: =?UTF-8?q?Cl=C3=A1udio=20Maia?= To: thomas.petazzoni@free-electrons.com, noralf@tronnes.org, gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] Staging: fbtft: fb_pcd8544: Fixed coding style errors and warnings Date: Tue, 3 Mar 2015 12:54:39 +0000 Message-Id: <1425387279-27397-2-git-send-email-crrm@isep.ipp.pt> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1425387279-27397-1-git-send-email-crrm@isep.ipp.pt> References: <1425387279-27397-1-git-send-email-crrm@isep.ipp.pt> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrMIsWRmVeSWpSXmKPExsVysMOqSldu/dcQg+1f1C0u75rD5sDo8XmT XABjFJdNSmpOZllqkb5dAlfGqdvn2AquSVQcbZ3L2MB4SbCLkYNDQsBEYmqzYxcjJ5ApJnHh 3nq2LkYuDiGB84wSXzZvZwJJCAm4S8zaexkqsZxJov35HhaQBJuAhcTVe53MILaIQLTE34WP WUFsZgE7ifOPdoLVCAuES9w6cwXMZhFQlZjT3sAIYvMKOEgsbzzNCnGEgsScSTYgYU4BR4kn x0+wQex1kDi29A4TRLmgxMmZT1hAypkF1CXWzxOC2CQv0bx1NvMERsFZSKpmIVTNQlK1gJF5 FaN4bmJmTnFqETBUDEz08lJL9DILCvQKSjYxQsKyZgfjvzeWhxgFOBiVeHhfcH4NEWJNLCuu zD3EKMnBpCTKG7YaKMSXlJ9SmZFYnBFfVJqTWnyIUYKDWUmEl3kuUI43JbGyKrUoHyYlzcGi JM6buSYzQEggPbEkNTs1tSC1CCYrw8GhJMGruA6oUbAoNT21Ii0zpwQhzcTBCTKcB2i4LEgN b3FBYm5xZjpE/hSjopQ4LzdIQgAkkVGaB9cLSxuvGMWBXhHmjQCp4gGmHLjuV0CDmYAG31L8 AjK4JBEhJdXAOJ/VojiI+xYzF5NNoW7YgZNVzxpjnn1kXykpUhBSZ7L40O/rDF0Ju9t+/rcI fqG+i33J6ciQyi/uRrZHfcpS41cEKEmuiIuff39JXgpjdmdyEE/UkraJx7eu3fPl+v39fubC 23lVv4WIpy55F5m+0SwsvWO1iYR2nKzbfN4AJ1uz7V+Pc+orsRRnJBpqMRcVJwIA1LKgFPYC AAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch corrects the comments' style. Signed-off-by: Cláudio Maia --- drivers/staging/fbtft/fb_pcd8544.c | 107 +++++++++++++++++++----------------- 1 file changed, 58 insertions(+), 49 deletions(-) diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/staging/fbtft/fb_pcd8544.c index a912c1a..fddb9cd 100644 --- a/drivers/staging/fbtft/fb_pcd8544.c +++ b/drivers/staging/fbtft/fb_pcd8544.c @@ -51,45 +51,50 @@ static int init_display(struct fbtft_par *par) par->fbtftops.reset(par); - /* Function set */ - write_reg(par, 0x21); /* - 5:1 1 - 2:0 PD - Powerdown control: chip is active - 1:0 V - Entry mode: horizontal addressing - 0:1 H - Extended instruction set control: extended - */ - - /* H=1 Temperature control */ - write_reg(par, 0x04 | (tc & 0x3)); /* - 2:1 1 - 1:x TC1 - Temperature Coefficient: 0x10 - 0:x TC0 - */ - - /* H=1 Bias system */ - write_reg(par, 0x10 | (bs & 0x7)); /* - 4:1 1 - 3:0 0 - 2:x BS2 - Bias System - 1:x BS1 - 0:x BS0 - */ - - /* Function set */ - write_reg(par, 0x22);/* - 5:1 1 - 2:0 PD - Powerdown control: chip is active - 1:1 V - Entry mode: vertical addressing - 0:0 H - Extended instruction set control: basic - */ - - /* H=0 Display control */ - write_reg(par, 0x08 | 4); /* - 3:1 1 - 2:1 D - DE: 10=normal mode - 1:0 0 - 0:0 E - */ + /* Function set + * + * 5:1 1 + * 2:0 PD - Powerdown control: chip is active + * 1:0 V - Entry mode: horizontal addressing + * 0:1 H - Extended instruction set control: extended + */ + write_reg(par, 0x21); + + /* H=1 Temperature control + * + * 2:1 1 + * 1:x TC1 - Temperature Coefficient: 0x10 + * 0:x TC0 + */ + write_reg(par, 0x04 | (tc & 0x3)); + + /* H=1 Bias system + * + * 4:1 1 + * 3:0 0 + * 2:x BS2 - Bias System + * 1:x BS1 + * 0:x BS0 + */ + write_reg(par, 0x10 | (bs & 0x7)); + + /* Function set + * + * 5:1 1 + * 2:0 PD - Powerdown control: chip is active + * 1:1 V - Entry mode: vertical addressing + * 0:0 H - Extended instruction set control: basic + */ + write_reg(par, 0x22); + + /* H=0 Display control + * + * 3:1 1 + * 2:1 D - DE: 10=normal mode + * 1:0 0 + * 0:0 E + */ + write_reg(par, 0x08 | 4); return 0; } @@ -99,16 +104,20 @@ static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye) fbtft_par_dbg(DEBUG_SET_ADDR_WIN, par, "%s(xs=%d, ys=%d, xe=%d, ye=%d)\n", __func__, xs, ys, xe, ye); - /* H=0 Set X address of RAM */ - write_reg(par, 0x80); /*7:1 1 - 6-0: X[6:0] - 0x00 - */ - - /* H=0 Set Y address of RAM */ - write_reg(par, 0x40); /*7:0 0 - 6:1 1 - 2-0: Y[2:0] - 0x0 - */ + /* H=0 Set X address of RAM + * + * 7:1 1 + * 6-0: X[6:0] - 0x00 + */ + write_reg(par, 0x80); + + /* H=0 Set Y address of RAM + * + * 7:0 0 + * 6:1 1 + * 2-0: Y[2:0] - 0x0 + */ + write_reg(par, 0x40); } static int write_vmem(struct fbtft_par *par, size_t offset, size_t len) -- 1.7.9.5