From: Jiri Olsa <jolsa@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Stephane Eranian <eranian@google.com>
Subject: [PATCH 09/14] perf tools: Use kmod_path__parse in decompress_kmodule
Date: Tue, 3 Mar 2015 16:29:36 +0100 [thread overview]
Message-ID: <1425396581-17716-10-git-send-email-jolsa@kernel.org> (raw)
In-Reply-To: <1425396581-17716-1-git-send-email-jolsa@kernel.org>
Replacing the file name parsing with kmod_path__parse.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
---
tools/perf/util/symbol-elf.c | 25 +++++++++++++++++--------
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c
index ada16762fac2..8dd530ce20c5 100644
--- a/tools/perf/util/symbol-elf.c
+++ b/tools/perf/util/symbol-elf.c
@@ -579,32 +579,41 @@ static int dso__swap_init(struct dso *dso, unsigned char eidata)
static int decompress_kmodule(struct dso *dso, const char *name,
enum dso_binary_type type)
{
- int fd;
- const char *ext = strrchr(name, '.');
+ int fd = -1, try = 2;
char tmpbuf[] = "/tmp/perf-kmod-XXXXXX";
+ struct kmod_path m;
if (type != DSO_BINARY_TYPE__SYSTEM_PATH_KMODULE_COMP &&
type != DSO_BINARY_TYPE__GUEST_KMODULE_COMP &&
type != DSO_BINARY_TYPE__BUILD_ID_CACHE)
return -1;
- if (!ext || !is_supported_compression(ext + 1)) {
- ext = strrchr(dso->name, '.');
- if (!ext || !is_supported_compression(ext + 1))
- return -1;
+again:
+ if (kmod_path__parse_ext(&m, name))
+ return -1;
+
+ if (!m.comp) {
+ if (!--try)
+ goto out;
+
+ free(m.ext);
+ name = dso->name;
+ goto again;
}
fd = mkstemp(tmpbuf);
if (fd < 0)
- return -1;
+ goto out;
- if (!decompress_to_file(ext + 1, name, fd)) {
+ if (!decompress_to_file(m.ext, name, fd)) {
close(fd);
fd = -1;
}
unlink(tmpbuf);
+out:
+ free(m.ext);
return fd;
}
--
1.9.3
next prev parent reply other threads:[~2015-03-03 15:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 15:29 [PATCH 0/3] perf tools: Adding xz decompression support Jiri Olsa
2015-03-03 15:29 ` [PATCH 01/14] perf tools: Remove superfluous thread->comm_set setting Jiri Olsa
2015-03-14 7:01 ` [tip:perf/core] perf tools: Remove superfluous thread-> comm_set setting tip-bot for Jiri Olsa
2015-03-03 15:29 ` [PATCH 02/14] perf tools: Add feature check for lzma library Jiri Olsa
2015-03-03 15:50 ` Arnaldo Carvalho de Melo
2015-03-03 15:57 ` Jiri Olsa
2015-03-03 15:29 ` [PATCH 03/14] perf tools: Add lzma decompression support for kernel module Jiri Olsa
2015-03-03 15:29 ` [PATCH 04/14] perf tools: Add kmod_path__parse function Jiri Olsa
2015-03-03 15:29 ` [PATCH 05/14] perf tools: Add dsos__new function Jiri Olsa
2015-03-03 16:20 ` Arnaldo Carvalho de Melo
2015-03-04 10:20 ` Jiri Olsa
2015-03-03 15:29 ` [PATCH 06/14] perf tools: Add machine__module_dso function Jiri Olsa
2015-03-03 15:29 ` [PATCH 07/14] perf tools: Use kmod_path__parse for machine__new_dso Jiri Olsa
2015-03-03 15:29 ` [PATCH 08/14] perf tools: Use kmod_path__parse in map_groups__set_modules_path_dir Jiri Olsa
2015-03-03 15:29 ` Jiri Olsa [this message]
2015-03-04 1:42 ` [PATCH 09/14] perf tools: Use kmod_path__parse in decompress_kmodule Namhyung Kim
2015-03-04 10:19 ` Jiri Olsa
2015-03-03 15:29 ` [PATCH 10/14] perf tools: Use kmod_path__parse in is_kernel_module Jiri Olsa
2015-03-03 15:29 ` [PATCH 11/14] perf tools: Remove compressed argument from is_kernel_module Jiri Olsa
2015-03-03 15:29 ` [PATCH 12/14] perf tools: Remove is_kmodule_extension function Jiri Olsa
2015-03-03 15:29 ` [PATCH 13/14] perf tools: Try to lookup kernel module map before creating one Jiri Olsa
2015-03-03 15:29 ` [PATCH 14/14] perf annotate: Allow annotation for decompressed kernel modules Jiri Olsa
2015-03-03 15:31 ` [PATCH 0/3] perf tools: Adding xz decompression support Jiri Olsa
2015-03-04 2:05 ` Namhyung Kim
2015-03-04 10:21 ` Jiri Olsa
2015-03-06 11:13 [PATCHv2 00/14] " Jiri Olsa
2015-03-06 11:13 ` [PATCH 09/14] perf tools: Use kmod_path__parse in decompress_kmodule Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425396581-17716-10-git-send-email-jolsa@kernel.org \
--to=jolsa@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome