From: Fabian Frederick <fabf@skynet.be>
To: linux-kernel@vger.kernel.org
Cc: Fabian Frederick <fabf@skynet.be>,
David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org
Subject: [PATCH 1/1 linux-next] jffs2: remove multiple dereferences in debug
Date: Tue, 3 Mar 2015 20:03:09 +0100 [thread overview]
Message-ID: <1425409389-21613-1-git-send-email-fabf@skynet.be> (raw)
use jffs2_eraseblock variables to simplify the code
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
fs/jffs2/debug.c | 26 ++++++++++++++------------
1 file changed, 14 insertions(+), 12 deletions(-)
diff --git a/fs/jffs2/debug.c b/fs/jffs2/debug.c
index 1090eb6..2ddb967 100644
--- a/fs/jffs2/debug.c
+++ b/fs/jffs2/debug.c
@@ -160,26 +160,28 @@ __jffs2_dbg_prewrite_paranoia_check(struct jffs2_sb_info *c,
void __jffs2_dbg_superblock_counts(struct jffs2_sb_info *c)
{
struct jffs2_eraseblock *jeb;
+ struct jffs2_eraseblock *gcb = c->gcblock;
+ struct jffs2_eraseblock *nextb = c->nextblock;
uint32_t free = 0, dirty = 0, used = 0, wasted = 0,
erasing = 0, bad = 0, unchecked = 0;
int nr_counted = 0;
int dump = 0;
- if (c->gcblock) {
+ if (gcb) {
nr_counted++;
- free += c->gcblock->free_size;
- dirty += c->gcblock->dirty_size;
- used += c->gcblock->used_size;
- wasted += c->gcblock->wasted_size;
- unchecked += c->gcblock->unchecked_size;
+ free += gcb->free_size;
+ dirty += gcb->dirty_size;
+ used += gcb->used_size;
+ wasted += gcb->wasted_size;
+ unchecked += gcb->unchecked_size;
}
- if (c->nextblock) {
+ if (nextb) {
nr_counted++;
- free += c->nextblock->free_size;
- dirty += c->nextblock->dirty_size;
- used += c->nextblock->used_size;
- wasted += c->nextblock->wasted_size;
- unchecked += c->nextblock->unchecked_size;
+ free += nextb->free_size;
+ dirty += nextb->dirty_size;
+ used += nextb->used_size;
+ wasted += nextb->wasted_size;
+ unchecked += nextb->unchecked_size;
}
list_for_each_entry(jeb, &c->clean_list, list) {
nr_counted++;
--
1.7.9.5
next reply other threads:[~2015-03-03 19:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 19:03 Fabian Frederick [this message]
2015-03-03 19:44 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425409389-21613-1-git-send-email-fabf@skynet.be \
--to=fabf@skynet.be \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®