From: Stanimir Varbanov <svarbanov@mm-sol.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@sonymobile.com>,
Stephen Boyd <sboyd@codeaurora.org>
Subject: [PATCH v2 1/2] pinctrl: qcom: enable generic pinconf
Date: Wed, 4 Mar 2015 12:41:56 +0200 [thread overview]
Message-ID: <1425465717-27747-2-git-send-email-svarbanov@mm-sol.com> (raw)
In-Reply-To: <1425465717-27747-1-git-send-email-svarbanov@mm-sol.com>
This makes the pinctrl driver to use the generic pinconf
interface. Mainly it gives us a way to use debugfs to dump
group configurations.
Signed-off-by: Stanimir Varbanov <svarbanov@mm-sol.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/pinctrl/qcom/pinctrl-msm.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
index a535f9c..d36e511 100644
--- a/drivers/pinctrl/qcom/pinctrl-msm.c
+++ b/drivers/pinctrl/qcom/pinctrl-msm.c
@@ -197,7 +197,6 @@ static int msm_config_reg(struct msm_pinctrl *pctrl,
*mask = 1;
break;
default:
- dev_err(pctrl->dev, "Invalid config param %04x\n", param);
return -ENOTSUPP;
}
@@ -262,9 +261,7 @@ static int msm_config_group_get(struct pinctrl_dev *pctldev,
arg = !!(val & BIT(g->in_bit));
break;
default:
- dev_err(pctrl->dev, "Unsupported config parameter: %x\n",
- param);
- return -EINVAL;
+ return -ENOTSUPP;
}
*config = pinconf_to_config_packed(param, arg);
@@ -357,6 +354,7 @@ static int msm_config_group_set(struct pinctrl_dev *pctldev,
}
static const struct pinconf_ops msm_pinconf_ops = {
+ .is_generic = true,
.pin_config_group_get = msm_config_group_get,
.pin_config_group_set = msm_config_group_set,
};
--
1.7.0.4
next prev parent reply other threads:[~2015-03-04 10:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 10:41 [PATCH v2 0/2] pinctrl: qcom: enable generic pinconf and input-enable Stanimir Varbanov
2015-03-04 10:41 ` Stanimir Varbanov [this message]
2015-03-04 14:36 ` [PATCH v2 1/2] pinctrl: qcom: enable generic pinconf Bjorn Andersson
2015-03-04 18:27 ` Stephen Boyd
2015-03-09 16:08 ` Linus Walleij
2015-03-04 10:41 ` [PATCH v2 2/2] pinctrl: qcom: handle input-enable pinconf property Stanimir Varbanov
2015-03-04 14:38 ` Bjorn Andersson
2015-03-04 18:28 ` Stephen Boyd
2015-03-09 16:09 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425465717-27747-2-git-send-email-svarbanov@mm-sol.com \
--to=svarbanov@mm-sol.com \
--cc=bjorn.andersson@sonymobile.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®