From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S934183AbbCDKrv (ORCPT <rfc822;w@1wt.eu>);
	Wed, 4 Mar 2015 05:47:51 -0500
Received: from ozlabs.org ([103.22.144.67]:52049 "EHLO ozlabs.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S933031AbbCDKrt (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 4 Mar 2015 05:47:49 -0500
Message-ID: <1425466067.32154.9.camel@ellerman.id.au>
Subject: Re: [PATCH] Remove redhat'ism from ftrace selftests.
From: Michael Ellerman <mpe@ellerman.id.au>
To: Shuah Khan <shuahkh@osg.samsung.com>
Cc: Namhyung Kim <namhyung@kernel.org>, Dave Jones <davej@codemonkey.org.uk>,
        Steven Rostedt <rostedt@goodmis.org>,
        Linux Kernel <linux-kernel@vger.kernel.org>
Date: Wed, 04 Mar 2015 21:47:47 +1100
In-Reply-To: <54F64C32.1030906@osg.samsung.com>
References: <20150224161927.GA4998@codemonkey.org.uk>
	 <20150224131810.38d73389@gandalf.local.home>
	 <54ECC182.5080109@osg.samsung.com>
	 <20150224182459.GA9018@codemonkey.org.uk> <20150228031602.GD15964@danjae>
	 <54F64C32.1030906@osg.samsung.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2015-03-03 at 17:05 -0700, Shuah Khan wrote:
> On 02/27/2015 08:16 PM, Namhyung Kim wrote:
> > On Tue, Feb 24, 2015 at 01:24:59PM -0500, Dave Jones wrote:
> >> On Tue, Feb 24, 2015 at 11:22:58AM -0700, Shuah Khan wrote:
> >>  > On 02/24/2015 11:18 AM, Steven Rostedt wrote:
> >>  > > 
> >>  > > Shuah,
> >>  > > 
> >>  > > Can you take this in your tree?
> >>  > 
> >>  > Yes I can do that. This must be the original patch email:
> >>  > https://lkml.org/lkml/2015/2/24/435
> > 
> > Please see below links:
> > 
> > https://lkml.org/lkml/2014/12/10/52
> > https://lkml.org/lkml/2014/12/22/556
> > 
> > I think we can get rid of the (u)sleeps entirely since 'cat trace'
> > itself should trigger scheduler events.
> 
> Steve/Dave,
> 
> Still good to take it through. The discussion in the threads
> Namhyung Kim pointed to seem to be inconclusive.
> 
> The only difference between the original patch
> https://lkml.org/lkml/2014/12/9/780
> and
> https://lkml.org/lkml/2015/2/24/435
> 
> is sleep duration change. I can take through my tree
> https://lkml.org/lkml/2015/2/24/435
> 
> just confirming.

No, the resoultion was that busybox doesn't support fractional sleeps and so
using them is not a solution.

I thought /bin/true would work, but never got around to testing it. The other
option was to use (echo "forked"):

https://lkml.org/lkml/2014/12/23/447

cheers