From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758404AbbCDLJn (ORCPT <rfc822;w@1wt.eu>);
	Wed, 4 Mar 2015 06:09:43 -0500
Received: from cpsmtpb-ews09.kpnxchange.com ([213.75.39.14]:56765 "EHLO
	cpsmtpb-ews09.kpnxchange.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1758372AbbCDLJl (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 4 Mar 2015 06:09:41 -0500
Message-ID: <1425467356.2798.8.camel@tiscali.nl>
Subject: Re: [PATCHv2 1/2] HSI: cmt_speech: Add cmt-speech driver
From: Paul Bolle <pebolle@tiscali.nl>
To: Sebastian Reichel <sre@kernel.org>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>,
        Kai Vehmanen <kvcontact@nosignal.fi>, Pavel Machek <pavel@ucw.cz>,
        Pali Rohar <pali.rohar@gmail.com>,
        Aaro Koskinen <aaro.koskinen@iki.fi>,
        Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
        linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-api@vger.kernel.org, Kai Vehmanen <kai.vehmanen@nokia.com>
Date: Wed, 04 Mar 2015 12:09:16 +0100
In-Reply-To: <1425343454-6551-2-git-send-email-sre@kernel.org>
References: <1425343454-6551-1-git-send-email-sre@kernel.org>
	 <1425343454-6551-2-git-send-email-sre@kernel.org>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.11 (3.12.11-1.fc21) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-OriginalArrivalTime: 04 Mar 2015 11:09:39.0000 (UTC) FILETIME=[B4E2DB80:01D0566B]
X-RcptDomain: vger.kernel.org
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

A license nit only.

Sebastian Reichel schreef op di 03-03-2015 om 01:44 [+0100]:
> --- /dev/null
> +++ b/drivers/hsi/clients/cmt_speech.c
> @@ -0,0 +1,1457 @@
> +/*
> + * cmt_speech.c - HSI CMT speech driver
> + *
> + * Copyright (C) 2008,2009,2010 Nokia Corporation. All rights reserved.
> + *
> + * Contact: Kai Vehmanen <kai.vehmanen@nokia.com>
> + * Original author: Peter Ujfalusi <peter.ujfalusi@nokia.com>
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License
> + * version 2 as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful, but
> + * WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
> + * 02110-1301 USA
> + */

This states the license is GPL v2.

> +MODULE_LICENSE("GPL");

So you probably want 
    MODULE_LICENSE("GPL v2");

here.


Paul Bolle