From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758547AbbCDLLr (ORCPT ); Wed, 4 Mar 2015 06:11:47 -0500 Received: from mailserver04.net.ipp.pt ([193.136.58.124]:47153 "EHLO mailserver04.net.ipp.pt" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758521AbbCDLLn (ORCPT ); Wed, 4 Mar 2015 06:11:43 -0500 X-AuditID: c1883a7c-f799e6d000001238-d4-54f6e86d648d From: =?UTF-8?q?Cl=C3=A1udio=20Maia?= To: thomas.petazzoni@free-electrons.com, noralf@tronnes.org, gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] Staging: fbtft: fb_pcd8544: Fixed coding style errors and warnings Date: Wed, 4 Mar 2015 11:11:13 +0000 Message-Id: <1425467473-12314-2-git-send-email-crrm@isep.ipp.pt> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1425467473-12314-1-git-send-email-crrm@isep.ipp.pt> References: <1425467473-12314-1-git-send-email-crrm@isep.ipp.pt> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrMIsWRmVeSWpSXmKPExsVysMOqSjf3xbcQg2kHNS0u75rD5sDo8XmT XABjFJdNSmpOZllqkb5dAlfGh7snmQv+ylWsbjrD0sC4UKSLkZNDQsBE4teOPSwQtpjEhXvr 2UBsIYHzjBIvVlZB2O4SP9bcZe9i5AKylzNJTHi7mxkkwSZgIXH1XieYLSIQLfF34WNWEJtZ wE7i/KOdYEOFBcIlbp25AmazCKhKHO65zAhi8wo4SDw7voCpi5EDaLGCxJxJNiBhTgFHiYOH p7BA7HWQWLPxJlS5oMTJmU9YQMqZBdQl1s8TgtgkL9G8dTbzBEbBWUiqZiFUzUJStYCReRWj eG5iZk5xahEwVAxM9PJSS/QyCwr0Cko2MULCsmYH4783locYBTgYlXh4M6K/hQixJpYVV+Ye YpTkYFIS5W1/AhTiS8pPqcxILM6ILyrNSS0+xCjBwawkwht7ESjHm5JYWZValA+TkuZgURLn zVyTGSAkkJ5YkpqdmlqQWgSTleHgUJLgtX0O1ChYlJqeWpGWmVOCkGbi4AQZzgM0fCpIDW9x QWJucWY6RP4Uo6KUOG8+SEIAJJFRmgfXC0sbrxjFgV4R5r30DKiKB5hy4LpfAQ1mAhp8S/EL yOCSRISUVANjfsG27kuTcy6nz3jK++vHdEcm69uNq4U+V0/+tvaqsLZfZKrORA1DCfWSHa91 up7Pj7t0pDv2/SXBs8UvePb/NGX+Ol8vTVzTzDKUT9uo7VG2TrPJqUnvDvx+ccJbW6s/dMJx k0l755nLrDj9/XZ9e1Dnrg91Wq0zmKTVljyKCheMK3/3890nJZbijERDLeai4kQAy14XgvYC AAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch fixes the following errors by refactoring the comments' style: WARNING: line over 80 characters ERROR: code indent should use tabs where possible Signed-off-by: Cláudio Maia --- drivers/staging/fbtft/fb_pcd8544.c | 107 ++++++++++++++++++++---------------- 1 file changed, 59 insertions(+), 48 deletions(-) diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/staging/fbtft/fb_pcd8544.c index dcb1c8b..f67e366 100644 --- a/drivers/staging/fbtft/fb_pcd8544.c +++ b/drivers/staging/fbtft/fb_pcd8544.c @@ -34,7 +34,7 @@ #define WIDTH 84 #define HEIGHT 48 #define TXBUFLEN (84*6) -#define DEFAULT_GAMMA "40" /* gamma is used to control contrast in this driver */ +#define DEFAULT_GAMMA "40" /* gamma controls the contrast in this driver */ static unsigned tc; module_param(tc, uint, 0); @@ -51,43 +51,50 @@ static int init_display(struct fbtft_par *par) par->fbtftops.reset(par); - /* Function set */ - write_reg(par, 0x21); /* 5:1 1 - 2:0 PD - Powerdown control: chip is active - 1:0 V - Entry mode: horizontal addressing - 0:1 H - Extended instruction set control: extended - */ - - /* H=1 Temperature control */ - write_reg(par, 0x04 | (tc & 0x3)); /* - 2:1 1 - 1:x TC1 - Temperature Coefficient: 0x10 - 0:x TC0 - */ - - /* H=1 Bias system */ - write_reg(par, 0x10 | (bs & 0x7)); /* - 4:1 1 - 3:0 0 - 2:x BS2 - Bias System - 1:x BS1 - 0:x BS0 - */ - - /* Function set */ - write_reg(par, 0x22); /* 5:1 1 - 2:0 PD - Powerdown control: chip is active - 1:1 V - Entry mode: vertical addressing - 0:0 H - Extended instruction set control: basic - */ - - /* H=0 Display control */ - write_reg(par, 0x08 | 4); /* - 3:1 1 - 2:1 D - DE: 10=normal mode - 1:0 0 - 0:0 E - */ + /* Function set + * + * 5:1 1 + * 2:0 PD - Powerdown control: chip is active + * 1:0 V - Entry mode: horizontal addressing + * 0:1 H - Extended instruction set control: extended + */ + write_reg(par, 0x21); + + /* H=1 Temperature control + * + * 2:1 1 + * 1:x TC1 - Temperature Coefficient: 0x10 + * 0:x TC0 + */ + write_reg(par, 0x04 | (tc & 0x3)); + + /* H=1 Bias system + * + * 4:1 1 + * 3:0 0 + * 2:x BS2 - Bias System + * 1:x BS1 + * 0:x BS0 + */ + write_reg(par, 0x10 | (bs & 0x7)); + + /* Function set + * + * 5:1 1 + * 2:0 PD - Powerdown control: chip is active + * 1:1 V - Entry mode: vertical addressing + * 0:0 H - Extended instruction set control: basic + */ + write_reg(par, 0x22); + + /* H=0 Display control + * + * 3:1 1 + * 2:1 D - DE: 10=normal mode + * 1:0 0 + * 0:0 E + */ + write_reg(par, 0x08 | 4); return 0; } @@ -97,16 +104,20 @@ static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye) fbtft_par_dbg(DEBUG_SET_ADDR_WIN, par, "%s(xs=%d, ys=%d, xe=%d, ye=%d)\n", __func__, xs, ys, xe, ye); - /* H=0 Set X address of RAM */ - write_reg(par, 0x80); /* 7:1 1 - 6-0: X[6:0] - 0x00 - */ - - /* H=0 Set Y address of RAM */ - write_reg(par, 0x40); /* 7:0 0 - 6:1 1 - 2-0: Y[2:0] - 0x0 - */ + /* H=0 Set X address of RAM + * + * 7:1 1 + * 6-0: X[6:0] - 0x00 + */ + write_reg(par, 0x80); + + /* H=0 Set Y address of RAM + * + * 7:0 0 + * 6:1 1 + * 2-0: Y[2:0] - 0x0 + */ + write_reg(par, 0x40); } static int write_vmem(struct fbtft_par *par, size_t offset, size_t len) -- 1.7.9.5