From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1759264AbbCDQdL (ORCPT <rfc822;w@1wt.eu>);
	Wed, 4 Mar 2015 11:33:11 -0500
Received: from mail-wi0-f178.google.com ([209.85.212.178]:39732 "EHLO
	mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1759072AbbCDQdJ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 4 Mar 2015 11:33:09 -0500
Message-ID: <1425486786.2769.25.camel@linaro.org>
Subject: Re: [PATCH 4.0-rc1 v17 4/6] printk: Simple implementation for NMI
 backtracing
From: Daniel Thompson <daniel.thompson@linaro.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Joe Perches <joe@perches.com>, Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>,
        Russell King <linux@arm.linux.org.uk>,
        Will Deacon <will.deacon@arm.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Marc Zyngier <marc.zyngier@arm.com>,
        Stephen Boyd <sboyd@codeaurora.org>,
        John Stultz <john.stultz@linaro.org>, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, patches@linaro.org,
        linaro-kernel@lists.linaro.org, Sumit Semwal <sumit.semwal@linaro.org>,
        Dirk Behme <dirk.behme@de.bosch.com>,
        Daniel Drake <drake@endlessm.com>,
        Dmitry Pervushin <dpervushin@gmail.com>,
        Tim Sander <tim@krieglstein.org>
Date: Wed, 04 Mar 2015 16:33:06 +0000
In-Reply-To: <20150304112010.338501ab@gandalf.local.home>
References: <1422022952-31552-1-git-send-email-daniel.thompson@linaro.org>
	 <1425463974-23568-1-git-send-email-daniel.thompson@linaro.org>
	 <1425463974-23568-5-git-send-email-daniel.thompson@linaro.org>
	 <1425485601.2712.9.camel@perches.com>
	 <20150304112010.338501ab@gandalf.local.home>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.11 (3.12.11-1.fc21) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2015-03-04 at 11:20 -0500, Steven Rostedt wrote:
> On Wed, 04 Mar 2015 08:13:21 -0800
> Joe Perches <joe@perches.com> wrote:
> 
> > On Wed, 2015-03-04 at 10:12 +0000, Daniel Thompson wrote:
> > > Currently there is a quite a pile of code sitting in
> > > arch/x86/kernel/apic/hw_nmi.c to support safe all-cpu backtracing from NMI.
> > > The code is inaccessible to backtrace implementations for other
> > > architectures, which is a shame because they would probably like to be
> > > safe too.
> > > 
> > > Copy this code into printk. We'll port the x86 NMI backtrace to it in a
> > > later patch.
> > 
> > I think this would be better as a separate file
> > rather than increasing the bulk of printk.c
> > 
> 
> I agree, as printk already has its own directory. Perhaps a
> "nmi_backtrace.c"?

I agree on moving the code. However, after Thomas' review I made sure
all the external symbols were prefixed printk_nmi and, as a result of
the same review I started using CONFIG_PRINTK_NMI to enable/disable the
feature). For that reason I'm much more inclined to name it
"printk_nmi.c". Any objections?

I know it is a somewhat generic name but I'll move the comment text that
commences "This is not a generic printk() implementation and must be
used with great care. In particular..." to the top of the file to make
clear the limitations of this code.


Daniel.