From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932523AbbCDS1z (ORCPT <rfc822;w@1wt.eu>);
	Wed, 4 Mar 2015 13:27:55 -0500
Received: from g1t5425.austin.hp.com ([15.216.225.55]:43647 "EHLO
	g1t5425.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1758301AbbCDS1x (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 4 Mar 2015 13:27:53 -0500
X-Greylist: delayed 88971 seconds by postgrey-1.27 at vger.kernel.org; Wed, 04 Mar 2015 13:27:53 EST
Message-ID: <1425493634.17007.248.camel@misato.fc.hp.com>
Subject: Re: [PATCH v8 7/7] x86, mm: Add set_memory_wt() for WT
From: Toshi Kani <toshi.kani@hp.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com,
        akpm@linux-foundation.org, arnd@arndb.de, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, jgross@suse.com,
        stefan.bader@canonical.com, luto@amacapital.net, hmh@hmh.eng.br,
        yigal@plexistor.com, konrad.wilk@oracle.com, Elliott@hp.com
Date: Wed, 04 Mar 2015 11:27:14 -0700
In-Reply-To: <1424961893.17007.139.camel@misato.fc.hp.com>
References: <1424823301-30927-1-git-send-email-toshi.kani@hp.com>
	 <1424823301-30927-8-git-send-email-toshi.kani@hp.com>
	 <20150225072228.GA13061@gmail.com>
	 <1424877601.17007.108.camel@misato.fc.hp.com>
	 <20150226113054.GA4191@gmail.com>
	 <1424961893.17007.139.camel@misato.fc.hp.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2015-02-26 at 07:44 -0700, Toshi Kani wrote:
> On Thu, 2015-02-26 at 12:30 +0100, Ingo Molnar wrote:
> > * Toshi Kani <toshi.kani@hp.com> wrote:
> > 
> > > On Wed, 2015-02-25 at 08:22 +0100, Ingo Molnar wrote:
> > > > * Toshi Kani <toshi.kani@hp.com> wrote:
> > > > 
> > > > > +int set_pages_array_wt(struct page **pages, int addrinarray)
> > > > > +{
> > > > > +	return _set_pages_array(pages, addrinarray, _PAGE_CACHE_MODE_WT);
> > > > > +}
> > > > > +EXPORT_SYMBOL(set_pages_array_wt);
> > > > 
> > > > So by default we make new APIs EXPORT_SYMBOL_GPL(): we 
> > > > don't want proprietary modules mucking around with new code 
> > > > PAT interfaces, we only want modules we can analyze and fix 
> > > > in detail.
> > > 
> > > Right.  I have one question for this case.  This 
> > > set_pages_array_wt() extends the set_pages_array_xx() 
> > > family, which are all exported with EXPORT_SYMBOL() 
> > > today.  In this case, should we keep them exported in the 
> > > consistent manner, or should we still use GPL when adding 
> > > a new one?
> > 
> > Still keep it GPL, it's a new API that old modules 
> > obviously don't use.
> 
> Got it. Thanks for the clarification.

Since this is a minor change and there is no other comment at this
point, I've submitted the updated patch 7/7 alone with the following
subject for saving your mail box. :-)

 [PATCH v8-UPDATE 7/7] x86, mm: Add set_memory_wt() for WT

Thanks,
-Toshi