From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752226AbbCDVix (ORCPT ); Wed, 4 Mar 2015 16:38:53 -0500 Received: from cpsmtpb-ews07.kpnxchange.com ([213.75.39.10]:61488 "EHLO cpsmtpb-ews07.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750919AbbCDViv (ORCPT ); Wed, 4 Mar 2015 16:38:51 -0500 Message-ID: <1425505128.2090.41.camel@tiscali.nl> Subject: Re: [PATCH 3/5] drm: jz4780: Add DRM driver for Ingenic JZ4780 From: Paul Bolle To: Zubair Lutfullah Kakakhel Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 04 Mar 2015 22:38:48 +0100 In-Reply-To: <1425483471-59808-4-git-send-email-Zubair.Kakakhel@imgtec.com> References: <1425483471-59808-1-git-send-email-Zubair.Kakakhel@imgtec.com> <1425483471-59808-4-git-send-email-Zubair.Kakakhel@imgtec.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 (3.12.11-1.fc21) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 04 Mar 2015 21:38:49.0052 (UTC) FILETIME=[99ABA9C0:01D056C3] X-RcptDomain: vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Zubair Lutfullah Kakakhel schreef op wo 04-03-2015 om 15:37 [+0000]: > --- /dev/null > +++ b/drivers/gpu/drm/jz4780/Makefile > @@ -0,0 +1,10 @@ > +ccflags-y := -Iinclude/drm > +ifeq (, $(findstring -W,$(EXTRA_CFLAGS))) > + > +endif What does that do? > +jz4780-y := \ > + jz4780_crtc.o \ > + jz4780_drv.o Please make this one line. > +obj-$(CONFIG_DRM_JZ4780) += jz4780.o > --- /dev/null > +++ b/drivers/gpu/drm/jz4780/jz4780_drv.c > @@ -0,0 +1,388 @@ > +/* > + * Copyright (C) 2015 Imagination Technologies > + * Author: Zubair Lutfullah Kakakhel > + * > + * DRM driver for Ingenic JZ4780 > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms of the GNU General Public License version 2 as published by > + * the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, but WITHOUT > + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or > + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for > + * more details. > + * > + */ This states the license is GPL v2. (I think the other files of this driver carry similar comments.) > +MODULE_LICENSE("GPL"); So you probably want MODULE_LICENSE("GPL v2"); here. Paul Bolle