From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753535AbbCDWcS (ORCPT <rfc822;w@1wt.eu>);
	Wed, 4 Mar 2015 17:32:18 -0500
Received: from cpsmtpb-ews09.kpnxchange.com ([213.75.39.14]:52137 "EHLO
	cpsmtpb-ews09.kpnxchange.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751284AbbCDWcQ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 4 Mar 2015 17:32:16 -0500
Message-ID: <1425508332.2090.48.camel@tiscali.nl>
Subject: Re: [PATCH v2] ASoC: Add support for NAU8824 codec to ASoC
From: Paul Bolle <pebolle@tiscali.nl>
To: Chih-Chiang Chang <ccchang12@nuvoton.com>
Cc: Mark Brown <broonie@kernel.org>,
        "mcuos.com@gmail.com" <mcuos.com@gmail.com>,
        "tiwai@suse.de" <tiwai@suse.de>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        liam.r.girdwood@intel.com
Date: Wed, 04 Mar 2015 23:32:12 +0100
In-Reply-To: <54F70052.1070109@nuvoton.com>
References: <54F70052.1070109@nuvoton.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.11 (3.12.11-1.fc21) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-OriginalArrivalTime: 04 Mar 2015 22:32:14.0204 (UTC) FILETIME=[10170BC0:01D056CB]
X-RcptDomain: vger.kernel.org
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Chih-Chiang Chang schreef op wo 04-03-2015 om 20:53 [+0800]:
> From fe37688e226f83ba477a3c2fbc1e64946cd4ec4e Mon Sep 17 00:00:00 2001
> From: Chih-Chiang Chang <ccchang12@nuvoton.com>
> Date: Wed, 4 Mar 2015 20:03:21 +0800
> Subject: [PATCH v2] ASoC: Add support for NAU8824 codec to ASoC

It seems that none of those lines were needed.

> --- /dev/null
> +++ b/include/sound/nau8824.h
> @@ -0,0 +1,22 @@
> +/*
> + * linux/sound/nau8824.h -- Platform data for NAU8824
> + *
> + * Copyright 2015 Nuvoton Technology Corp.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +
> +#ifndef __LINUX_SND_NAU8824_H
> +#define __LINUX_SND_NAU8824_H
> +
> +struct nau8824_platform_data {
> +       unsigned int audio_mclk1;
> +       unsigned int gpio_irq;
> +       int naudint_irq;
> +       int headset_detect;
> +       int button_press_detect;
> +};
> +
> +#endif

In the future something other than just sound/soc/codecs/nau8824.h is
going to include this header, right?

> --- /dev/null
> +++ b/sound/soc/codecs/nau8824.c
> @@ -0,0 +1,807 @@
> +/*
> + * linux/sound/soc/codecs/nau8824.c
> + *
> + * Copyright 2015 Nuvoton Technology Corp.
> + * Author: Meng-Huang Kuo <mhkuo@nuvoton.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */

This states the license is GPL v2. (So do the two headers this patch
adds.)

> +MODULE_LICENSE("GPL");

So that should probably be
    MODULE_LICENSE("GPL v2");


Paul Bolle