From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754341AbbCEC4G (ORCPT <rfc822;w@1wt.eu>);
	Wed, 4 Mar 2015 21:56:06 -0500
Received: from ozlabs.org ([103.22.144.67]:54928 "EHLO ozlabs.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753860AbbCEC4D (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 4 Mar 2015 21:56:03 -0500
Message-ID: <1425524162.32154.18.camel@ellerman.id.au>
Subject: Re: [PATCH] ftracetest: Don't use non-POSIX exit -1
From: Michael Ellerman <mpe@ellerman.id.au>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: shuahkh@osg.samsung.com, linux-kernel@vger.kernel.org,
        davej@codemonkey.org.uk, namhyung@kernel.org
Date: Thu, 05 Mar 2015 13:56:02 +1100
In-Reply-To: <20150304212659.3e1d1414@grimm.local.home>
References: <1425521042-30251-1-git-send-email-mpe@ellerman.id.au>
	 <20150304212659.3e1d1414@grimm.local.home>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2015-03-04 at 21:26 -0500, Steven Rostedt wrote:
> On Thu,  5 Mar 2015 13:04:02 +1100
> Michael Ellerman <mpe@ellerman.id.au> wrote:
> 
> > POSIX says that exit takes an unsigned integer between 0 and 255.
> > 
> > Convert exit -1 to exit 255.
> > 
> 
> Why 255? Why not just exit 1?

I was trying to emulate the current behaviour:

$ /bin/bash
$ exit -1
exit
$ echo $?
255

> Actually, don't we have explicit numbers for exit status?
> 
> /me not looking at the code right now to figure that out.

Yeah looks like it, and some interesting signal handling tricks:

  https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/tools/testing/selftests/ftrace/ftracetest#n123

I'll send a new version using "exit $FAIL" ?

cheers