From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Maxime Ripard <maxime.ripard@free-electrons.com>
Subject: [PATCH v3 1/5] clocksource: sun5i: Switch to request_irq
Date: Thu, 5 Mar 2015 11:20:52 +0100 [thread overview]
Message-ID: <1425550856-12928-2-git-send-email-maxime.ripard@free-electrons.com> (raw)
In-Reply-To: <1425550856-12928-1-git-send-email-maxime.ripard@free-electrons.com>
The current code uses setup_irq, while it could perfectly use the much simpler
request_irq. Switch to that.
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
drivers/clocksource/timer-sun5i.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/clocksource/timer-sun5i.c b/drivers/clocksource/timer-sun5i.c
index 02268448dc85..836f92ac0ffd 100644
--- a/drivers/clocksource/timer-sun5i.c
+++ b/drivers/clocksource/timer-sun5i.c
@@ -130,13 +130,6 @@ static irqreturn_t sun5i_timer_interrupt(int irq, void *dev_id)
return IRQ_HANDLED;
}
-static struct irqaction sun5i_timer_irq = {
- .name = "sun5i_timer0",
- .flags = IRQF_TIMER | IRQF_IRQPOLL,
- .handler = sun5i_timer_interrupt,
- .dev_id = &sun5i_clockevent,
-};
-
static u64 sun5i_timer_sched_read(void)
{
return ~readl(timer_base + TIMER_CNTVAL_LO_REG(1));
@@ -178,7 +171,8 @@ static void __init sun5i_timer_init(struct device_node *node)
ticks_per_jiffy = DIV_ROUND_UP(rate, HZ);
- ret = setup_irq(irq, &sun5i_timer_irq);
+ ret = request_irq(irq, sun5i_timer_interrupt, IRQF_TIMER | IRQF_IRQPOLL,
+ "sun5i_timer0", &sun5i_clockevent);
if (ret)
pr_warn("failed to setup irq %d\n", irq);
--
2.3.0
next prev parent reply other threads:[~2015-03-05 10:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-05 10:20 [PATCH v3 0/5] clocksource: sun5i: Support parent clock rate changes Maxime Ripard
2015-03-05 10:20 ` Maxime Ripard [this message]
2015-03-05 10:20 ` [PATCH v3 2/5] clocksource: sun5i: Use of_io_request_and_map Maxime Ripard
2015-03-05 10:20 ` [PATCH v3 3/5] clocksource: sun5i: Remove sched_clock Maxime Ripard
2015-03-05 10:20 ` [PATCH v3 4/5] clocksource: sun5i: Refactor the current code Maxime Ripard
2015-03-05 14:30 ` Daniel Lezcano
2015-03-05 14:32 ` [PATCH] " Daniel Lezcano
2015-03-05 15:44 ` Maxime Ripard
2015-03-05 10:20 ` [PATCH v3 5/5] clocksource: sun5i: Add clock notifiers Maxime Ripard
2015-03-19 22:53 ` [PATCH v3 0/5] clocksource: sun5i: Support parent clock rate changes Maxime Ripard
2015-03-20 14:04 ` Daniel Lezcano
2015-03-20 20:56 ` Maxime Ripard
2015-03-21 10:43 ` Hans de Goede
2015-03-23 16:54 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425550856-12928-2-git-send-email-maxime.ripard@free-electrons.com \
--to=maxime.ripard@free-electrons.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®